From: Martin Spinler <spinler@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching
Date: Mon, 14 Feb 2022 17:53:49 +0100 [thread overview]
Message-ID: <396d49dabb50ea0e092ed6e5da0074a0c3765ef6.camel@cesnet.cz> (raw)
In-Reply-To: <01628a95-64e4-e416-413d-5b4623b38a85@intel.com>
On Mon, 2022-02-14 at 13:36 +0000, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote:
> > From: Martin Spinler <spinler@cesnet.cz>
> >
> > In the firmware, the promisc mode overrides the multicast mode.
> > So when the promisc mode is turned off, driver must check if the
> > multicast mode was active before and conditionally reactivate it.
> >
>
> Can you please add fixes & stable tags.
Tags will be added in v2.
>
> > Signed-off-by: Martin Spinler <spinler@cesnet.cz>
> > ---
> > drivers/net/nfb/nfb.h | 4 ----
> > drivers/net/nfb/nfb_ethdev.c | 1 -
> > drivers/net/nfb/nfb_rxmode.c | 20 ++++++++------------
> > 3 files changed, 8 insertions(+), 17 deletions(-)
> >
>
> <...>
next prev parent reply other threads:[~2022-02-14 16:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:25 [PATCH 1/6] net/nfb: add missing libfdt dependency for build spinler
2022-02-14 11:25 ` [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions spinler
2022-02-14 13:34 ` Ferruh Yigit
2022-02-14 16:52 ` Martin Spinler
2022-02-14 11:25 ` [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst spinler
2022-02-14 13:35 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:34 ` Ferruh Yigit
2022-02-14 11:25 ` [PATCH 4/6] drivers/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-14 11:25 ` [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching spinler
2022-02-14 13:36 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler [this message]
2022-02-14 11:25 ` [PATCH 6/6] drivers/nfb: add support for more MAC addresses spinler
2022-02-14 13:37 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:54 ` Ferruh Yigit
2022-02-15 13:02 ` Martin Spinler
2022-02-14 13:36 ` [PATCH 1/6] net/nfb: add missing libfdt dependency for build Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-15 12:55 ` [PATCH v2 0/5] " spinler
2022-02-15 12:55 ` [PATCH v2 1/5] net/nfb: fix array indexes in deinit functions spinler
2022-02-15 12:55 ` [PATCH v2 2/5] net/nfb: do not report zero-sized TX burst spinler
2022-02-15 12:55 ` [PATCH v2 3/5] net/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-15 12:55 ` [PATCH v2 4/5] net/nfb: fix multicast/promiscuous mode switching spinler
2022-02-15 12:55 ` [PATCH v2 5/5] net/nfb: add support for more MAC addresses spinler
2022-02-15 13:55 ` [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build Ferruh Yigit
2022-02-15 13:57 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396d49dabb50ea0e092ed6e5da0074a0c3765ef6.camel@cesnet.cz \
--to=spinler@cesnet.cz \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).