From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0475BA034E;
	Mon, 14 Feb 2022 17:53:51 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EAD5E40DDA;
	Mon, 14 Feb 2022 17:53:50 +0100 (CET)
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by mails.dpdk.org (Postfix) with ESMTP id 009454067E
 for <dev@dpdk.org>; Mon, 14 Feb 2022 17:53:49 +0100 (CET)
Received: from [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f] (unknown
 [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id CB7A5400074;
 Mon, 14 Feb 2022 17:53:49 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2-2020; t=1644857629;
 bh=Pskm0/QVX6+xda+rZBvzNhasWFpu4hJi+kiwFE80jh0=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=bzEMFpQmPTtLFkEBUnnYtFmnAf2hcXLurII9KIcP/BXebKoxorranEpenxsFgEU60
 sl49MUHdXWGBzxy+Mvb/3LggUiEuCG6QWGmTEAk3JtKZ3raWCDIrusXS0iHzMw8Gn/
 mQtEtsRsYsMY4V2kW79zY7pUibxd7V3z/W/cBwkfkFhHOM8lCn8PdeOrzYFKxPaPY0
 rlqKhQt+iTT/Dgniao2aRILX8Wqjn1g5q8Cheqy21X2QVKDi141D7UZ9pBlki5PC4k
 KKSdjlo/3sZ58AlRLZxzWSmTK+/wFvUYS1+Np/DgdbMn7uh5NyYX5cQyp7aeB/O0nD
 1BI/5Uz4akhEw==
Message-ID: <396d49dabb50ea0e092ed6e5da0074a0c3765ef6.camel@cesnet.cz>
Subject: Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching
From: Martin Spinler <spinler@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Date: Mon, 14 Feb 2022 17:53:49 +0100
In-Reply-To: <01628a95-64e4-e416-413d-5b4623b38a85@intel.com>
References: <20220214112541.29782-1-spinler@cesnet.cz>
 <20220214112541.29782-5-spinler@cesnet.cz>
 <01628a95-64e4-e416-413d-5b4623b38a85@intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, 2022-02-14 at 13:36 +0000, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote:
> > From: Martin Spinler <spinler@cesnet.cz>
> > 
> > In the firmware, the promisc mode overrides the multicast mode.
> > So when the promisc mode is turned off, driver must check if the
> > multicast mode was active before and conditionally reactivate it.
> > 
> 
> Can you please add fixes & stable tags.

Tags will be added in v2.

> 
> > Signed-off-by: Martin Spinler <spinler@cesnet.cz>
> > ---
> >   drivers/net/nfb/nfb.h        |  4 ----
> >   drivers/net/nfb/nfb_ethdev.c |  1 -
> >   drivers/net/nfb/nfb_rxmode.c | 20 ++++++++------------
> >   3 files changed, 8 insertions(+), 17 deletions(-)
> > 
> 
> <...>