From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 1BE7AFE5 for ; Fri, 15 May 2015 14:51:21 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so61026160wic.0 for ; Fri, 15 May 2015 05:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GFTIEvtWkIX8kRKQRyjfej7NosBDyr3c95MygzluxXc=; b=bplppofbm+FQKux2x3tKtOc4xOlDcKQyLllgCSzzLrSAwjckCI8f2mbVf860tU760U HgUtxnV3FelNjeEA1+xbpJAwG0AeID+mNm5U5wzvXlm/E6911PKR/ykoNky3kxfQgmNt KHjh0X4BtkVaSVqZlRUvylGmOmnV7Qwa1l6xr9V0/AhRZUnpbWJ3RZ+bTmfAH+UNLmuc xd94kytIxm1QUPDSwYnqdrcnVt84zeZtUomssA3ydAO/Wkfi+RY8SBe/mriX9DQWrqvP JabIWfpibe29xrGWUmfZ/iUCNV6R4VSyAnG/pEWyG54NpFEXbjO9Iex9ixGfiSiVykzP p28w== X-Gm-Message-State: ALoCoQngxQKZJz3JTfU674jhdOENE7NgGLJjokFF5QUg8Twr2mn0M6PVQxJ0PKBbvRz2CojifWPE X-Received: by 10.195.17.232 with SMTP id gh8mr17657081wjd.145.1431694280951; Fri, 15 May 2015 05:51:20 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l1sm3113406wiy.20.2015.05.15.05.51.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2015 05:51:20 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Fri, 15 May 2015 14:50:37 +0200 Message-ID: <39769837.qq9gic58Ll@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <20150515123637.GA10656@bricha3-MOBL3> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <20150513134048.GA13080@bricha3-MOBL3> <20150515123637.GA10656@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 12:51:21 -0000 2015-05-15 13:36, Bruce Richardson: > On Wed, May 13, 2015 at 02:40:48PM +0100, Bruce Richardson wrote: > > On Wed, May 13, 2015 at 03:33:27PM +0200, Thomas Monjalon wrote: > > > 2015-05-13 11:01, Bruce Richardson: > > > > On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote: > > > >> 2015-05-12 19:04, Bruce Richardson: > > > >>> drivers/e1000/e1000/e1000_hw.h | 1026 ++++ > > > >> > > > >> As explained in a previous comment, > > > >> http://dpdk.org/ml/archives/dev/2015-May/017509.html > > > >> I think this path would be better: > > > >> drivers/net/e1000/base/e1000_hw.h > > > > > > > > Two reasons why I didn't create the "net" subfolder: > > > > 1. I initally forgot to consider it :-( > > > > 2. While we may at some future point have other device driver types, are we really > > > > needing to start categorising PMDs at this point? > > > > > > > > As for the base driver part, I was viewing that as a something that should be > > > > a separate patch set, since it's unrelated to moving things to the drivers > > > > subdir. > > > > > > I understand your points and I partially agree. > > > However, file moves may be perturbing because it change habits > > > and may complicate a bit the git history browsing. > > > So I think it's better to minimize such moves and do altogether. > > > > > Ok. I'll see about renaming the base code directories as part of the overall > > move process [Unless there are objections from any of the driver maintainers]. > > > > As for drivers vs drivers/net, I suppose there is no real difference in what > > the path actually is, so I can make that change too. However, I still think I > > prefer the shorter path. Anyone else any opinions on this [before I start > > reworking this again]? > > > > /Bruce > > Hi Thomas, > > a specific question on how you want the rename of the "base" driver directories. > Can I take it from your question that you want the base driver renaming to be > merged into a single commit with the rest of the move for the driver? For example, > as part of the patch move from "lib/librte_pmd_e1000" to "drivers/net/e1000" we > also rename the "e1000" subdir to "base". Yes, to minimize number of patches moving files (and breaking history for some tools). > The slight problem with this approach - of trying to do both moves in a single > patch is that the rename of the subdirectory "e1000" involves changes to other > files in the librte_pmd_e1000 directory which are being moved, so we can't > have a clean patch that just moves files and doesn't touch those files which are > being moved. Therefore, from a patch cleanliness point of view, the renames > to the base directory should be a separate patch, which I can make part of this > series. The changes are only in Makefile and include lines, right? I think it's not a big deal to have small changes. But maybe it will make difficult to read the move with some tools. Feel free to adopt the solution you prefer if nobody else has an experienced opinion.