From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83A20A09FD; Fri, 18 Dec 2020 19:49:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDCF9CAD1; Fri, 18 Dec 2020 19:49:10 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9386FCAB2 for ; Fri, 18 Dec 2020 19:49:09 +0100 (CET) IronPort-SDR: wuh7AE+9nmDxkS6oEhOs4z+ow5sqxGr5Er9pQgktyEOsqAsxSROynUVv10G3F54ZeBvdUSA0M5 jH5u+jQCuIkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9839"; a="163219609" X-IronPort-AV: E=Sophos;i="5.78,431,1599548400"; d="scan'208";a="163219609" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 10:49:07 -0800 IronPort-SDR: 0M0f1ad7NShKuCQ/aBTVpcbszzAfLRVae2VX8bt4tmfumExayUj9Wug6GVvWaCOo28D6a5Rcg5 sLX2yUem36kQ== X-IronPort-AV: E=Sophos;i="5.78,431,1599548400"; d="scan'208";a="354146138" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.212.192.23]) ([10.212.192.23]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 10:49:07 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, beilei.xing@intel.com, jia.guo@intel.com References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201217225909.3580-1-pallavi.kadam@intel.com> <20201217225909.3580-2-pallavi.kadam@intel.com> <1972131.Zv2h2cGNgz@thomas> From: "Kadam, Pallavi" Message-ID: <397cccde-fa62-961a-220d-94a54a550a68@intel.com> Date: Fri, 18 Dec 2020 10:49:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <1972131.Zv2h2cGNgz@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/18/2020 3:29 AM, Thomas Monjalon wrote: > 17/12/2020 23:59, Pallavi Kadam: >> This file is required to compile and build i40e PMD on Windows. >> Add rte_rand variable to export file. >> >> Redefine _m_prefetchw for Clang toolchain due to following error >> with respect to conflicting types: >> >> FAILED: lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj >> clang @lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj.rsp >> In file included from ../lib/librte_eal/common/rte_random.c:13: >> In file included from ..\lib/librte_eal/include\rte_eal.h:20: >> In file included from ..\lib/librte_eal/include\rte_per_lcore.h:25: >> In file included from ..\lib/librte_eal/windows/include\pthread.h:21: >> In file included from ..\lib/librte_eal/windows/include\rte_windows.h:27: >> In file included from C:\Program Files (x86)\Windows Kits\10\include\ >> 10.0.18362.0\um\windows.h:171: >> In file included from C:\Program Files (x86)\Windows Kits\10\include\ >> 10.0.18362.0\shared\windef.h:24: >> In file included from C:\Program Files (x86)\Windows Kits\10\include\ >> 10.0.18362.0\shared\minwindef.h:182: >> C:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um\ >> winnt.h:3324:1: error: conflicting types for '_m_prefetchw' >> _m_prefetchw ( >> ^ >> C:\Program Files\LLVM\lib\clang\10.0.0\include\prfchwintrin.h:50:1: >> note: previous definition is here >> _m_prefetchw(void *__P) >> ^ >> 1 error generated. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Ranjit Menon >> --- >> +#ifdef RTE_TOOLCHAIN_CLANG >> +#undef _m_prefetchw >> +#define _m_prefetchw __m_prefetchw >> +#endif > It deserves a comment explaining why __m_prefetchw is required. Will add a comment in v3. Thanks! > > >