From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 9314D6895 for ; Wed, 14 May 2014 12:33:40 +0200 (CEST) Received: by mail-wi0-f173.google.com with SMTP id bs8so7757530wib.0 for ; Wed, 14 May 2014 03:33:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TVTWNubQesrdqcXJNj0UISSCKv/sVGSNDoDI8MPPYrk=; b=Xblap+Os856TskGqRZZCOBs3F6Zi1T+M9+vQSzjReR/UWNCXlJ4SDHpCj8VQYhFsel d43KxFjR/tVj5UJFLSyR0GtE9y/ViWPI4n9WyihX2LrRRC/i3S6XsST0HSDzNUVdmj6s FIOyZrfPTG9RxRK4aFPn/4so2zSwcjDsBZkxwVfP4WGdJUYEOPfu7b+DizNorYhamo2J s0839luEfpqZVNlHV47rKzes5g80tnVUVc8U20/xWTVnpj1ozN5lNAYRYBjZB9v44aye +EI2RMHCs+mIdXTg2ux/WFnr1xoRToaQPC2W5EGmzkmyws/mETJs58M8T3FuxY6/vWnl gKjw== X-Gm-Message-State: ALoCoQmeo1OAxdmNz5qJJVo6u/ujRn1wF+ZvJr9vqOssBjLU2OO6HoOP0YMR/cp1XXxt0XWEUnNd X-Received: by 10.180.85.134 with SMTP id h6mr25346937wiz.44.1400063628165; Wed, 14 May 2014 03:33:48 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id pn9sm26994970wic.17.2014.05.14.03.33.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 May 2014 03:33:47 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 14 May 2014 12:33:46 +0200 Message-ID: <3983181.2kuc6T3mxt@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.2-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: allow updates to build config on make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 10:33:40 -0000 Hi Bruce 2014-05-14 11:22, Bruce Richardson: > There was an issue with rebuilding the code following a change to > one of the config files inside the "config" directory. If one did > a "make install T=" and then made a modification to the > defconfig_ file (or applied a patch which modified that file) > a subsequent re-run of the make install command would not rebuild > the .config file leading to either build failures or an incorrect > build. This change fixes that issue. Your patch is reverting this one: mk: in install rule, don't overwrite .config if it already exists http://dpdk.org/browse/dpdk/commit/?id=1c858a7dfebd4e4092eb55 As stated in the commit log, "This allows the user to prepare a configuration with make config before using make install." So your patch is introducing a regression. I think you are describing something which is not a bug. If you make a modification to the configuration template, you must explicitly call "make config". -- Thomas