From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 00223106B for ; Mon, 23 Mar 2015 15:02:34 +0100 (CET) Received: by weop45 with SMTP id p45so138662224weo.0 for ; Mon, 23 Mar 2015 07:02:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=U5ryeAVt+mh6WV4HobLiYobv2/j0fQE5PTlApAAskH0=; b=PE42VagvrmNHVBp6v+PLJSnZ2UgNj+fpkVAFWURxyMOLsjKPp7NKOqSn41+DCYDdH2 Hdw4YulxFBFhz2n/BtV1+O8BdMk2WvcpSpRnawlA4RifS/lTWBwFMTv1kJPnpuUP0j/Z BFs9jrxV9g+R7VYF96iRs4fJQnPMFNL5XSj4g9Jmbi8x/inAjE2aNWY8T8Ug888Dh594 m/bfekYB1D2uncviAU7DlSX49bV9aZ7rD6S4kmrs3hlDY2jMjecI/3uUQbGgS2vYynFT 4J1u8WYuyUTARikFL8Z+qTQCPSCoFVIEqC96oMhMBLBeqX2uZx9miBb2nciKpRnOZAtt GV3Q== X-Gm-Message-State: ALoCoQnsJFsf6VBbDvqLEfZcpC3lRNzI6nCLYRoCbH2AxKfrPciso7zgkchCRqxQK+Oh19QW6498 X-Received: by 10.194.47.201 with SMTP id f9mr181819245wjn.17.1427119354861; Mon, 23 Mar 2015 07:02:34 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id e2sm1488844wjy.46.2015.03.23.07.02.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 07:02:33 -0700 (PDT) From: Thomas Monjalon To: xuelin.shi@freescale.com Date: Mon, 23 Mar 2015 15:01:53 +0100 Message-ID: <3986979.AOFPnzYeq1@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425371224-15631-1-git-send-email-xuelin.shi@freescale.com> References: <1425371224-15631-1-git-send-email-xuelin.shi@freescale.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix data access on big endian cpu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:02:35 -0000 2015-03-03 16:27, xuelin.shi@freescale.com: > From: Xuelin Shi > > enforce rules for cpu and ixgbe exchanging data. > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) > 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) > > Signed-off-by: Xuelin Shi Please Xuelin, could you rebase on HEAD and fix these checkpatch errors? ERROR:SPACING: space prohibited after that '!' (ctx:BxW) ERROR:CODE_INDENT: code indent should use tabs where possible +^I^I ^I ^I IXGBE_RXDADV_STAT_DD)) {$ Thanks