From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id CB5717E92
 for <dev@dpdk.org>; Tue,  4 Nov 2014 19:51:57 +0100 (CET)
Received: by mail-wi0-f171.google.com with SMTP id q5so10308554wiv.16
 for <dev@dpdk.org>; Tue, 04 Nov 2014 11:01:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=6mhdIap9AK/16yH4nRX3cEw/MMiYcDAiN4O18WHnUh8=;
 b=IiBzyXxZIJcMFO07CUHWHWVVM/npDP5M4K2ft+jNh2Ah8/oiUg6nxk/Dugxp7MYkbx
 zWf76tXPnhXoZ0t/xGx94Lxios7n70kvmUEQfcnNE2ilbKXav8c1bnucur7R2hmIDQSA
 tTMrFXRYIzKedy1YnEAKkC8lXY9MHFy6lfo8k84ZqessqijLSAjXHRAHyO+UEoWD1olw
 ScgdlpVsvvKKa5dtyw0fQ0nIUEfshY6GP+QvJkWEwwmL0kqIaDZxCSglAJOrQwXsPLvL
 PrLRGaRDTS7UjfA7UBEMpz5HboLZl8EwRfPrAw1UQc/YSQMwSIPP7JY9hwA5FNH9TGjD
 /Viw==
X-Gm-Message-State: ALoCoQmC6jYS5NuoW1qLVJAcWwkFLRbmxw1MjsH33lTeto3Gib4xSJsK0ZCKtPF/+EVbEvMPTCYY
X-Received: by 10.180.106.162 with SMTP id gv2mr26298516wib.26.1415127677372; 
 Tue, 04 Nov 2014 11:01:17 -0800 (PST)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id wc7sm1515925wjc.8.2014.11.04.11.01.15
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Nov 2014 11:01:16 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Aaron Campbell <aaron@arbor.net>
Date: Tue, 04 Nov 2014 20:00:58 +0100
Message-ID: <3986981.sR7Aq8MzkS@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>
References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>
 <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify
	master lcore id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2014 18:51:58 -0000

2014-11-03 13:02, Aaron Campbell:
> > On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer@neclab.eu>=
 wrote:
> >=20
> > +=09=09=09else if (!strcmp(lgopts[option_index].name, OPT_MASTER_LC=
ORE)) {
> > +=09=09=09=09if (!coremask_ok) {
> > +=09=09=09=09=09RTE_LOG(ERR, EAL, "please specify the master "
> > +=09=09=09=09=09=09=09"lcore id after specifying "
> > +=09=09=09=09=09=09=09"the coremask\n");
> > +=09=09=09=09=09eal_usage(prgname);
> > +=09=09=09=09=09return -1;
> > +=09=09=09=09}
>=20
>=20
> Hi Simon,
>=20
> I think that forcing a particular command line order is not that clea=
n.
> It might be better to remove the cfg->master_lcore setting from
> eal_parse_coremask(), and defer the selection of the master lcore unt=
il
> all of the command-line options have been parsed.  If =E2=80=94master=
-lcore was
> specified, save the value and use that, otherwise
> rte_get_next_lcore(-1, 0, 0) can return the first bit set in the core=
mask.

It's not sufficient: eal_parse_master_lcore() requires cfg->lcore_role
to be set. There is a real dependency between these 2 options.
I'm going to submit a v2. Feel free to improve it with another patch.

--=20
Thomas