From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC1FDA0508; Thu, 14 Apr 2022 15:14:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7151640694; Thu, 14 Apr 2022 15:14:59 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B82D740687 for ; Thu, 14 Apr 2022 15:14:58 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4710F5C01EF; Thu, 14 Apr 2022 09:14:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 14 Apr 2022 09:14:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1649942098; x= 1650028498; bh=2+u1rrmxj4yYBFcdiN0in/CeOlbnCp9wt4J4X3XiwMg=; b=D /CNxyOpXVAV+XQFRS1ltD5gSjeeE/2WG9OITW5CZAfX0qUFNWzxP5QayD/jZK/vf 4r35CASJM2EDCy152a+BgPop5VX5d4vBGXV28mUCWI7kuH7U/r4aWaOeqaGCYtbw 1FDJMaZ6PY1ijwIHBu46mCgW/DHJ4dLylgdCLT/RP/rUAhvff4itYxvoZh2a06mo zC9qLwy9oWT6IXwLbL/73WLv5ZotHUvC03hS2CyhngwtpjSgeykZz1oU4VzwVQuI tt5Vfve7ITyhk3KXWFfs6hp+1rvEth8+yiPQJMu3p/mHWtzkQ6rGTqZ9UigzYoP8 JmhSMuNMy9JsgOEec7KiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1649942098; x=1650028498; bh=2+u1rrmxj4yYB FcdiN0in/CeOlbnCp9wt4J4X3XiwMg=; b=xIQrMPsoDj0YrOZTQjjL8wu52AfyT KTW/cug+uB5AHfOEEH8U+uSrDkWcpLfPn1lCp/dGOty+Z7j4Dp1Hbncrvkq5XtcR mHaeSkDh1HYtSyHFB5HAbONHiqfd75al6WjzlzLjc+qeAS6379ZOJ1b8DuIyJKLX YQbWUIS/5fUxu4TapgA/ZvXnTw0oue8sCfRx5Av57HiQrbB+yDLbFeuw6ADDdtZN 6WYnxvH6w0ANC/XmhPMsXVlQHUoS8D0WTUb7e+nAQpYa8KgqR2DkrtWGxskJl0MC SrWzHc+Y4m1mW9Qf4QNI/Jnk6MXUHd1wnHthwEMngeT81vbDt/PesqbSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelfedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Apr 2022 09:14:57 -0400 (EDT) From: Thomas Monjalon To: Huichao Cai Cc: dev@dpdk.org, konstantin.ananyev@intel.com Subject: Re: [PATCH v6] ip_frag: add IPv4 options fragment and test data Date: Thu, 14 Apr 2022 15:14:56 +0200 Message-ID: <3987029.6PsWsQAL7t@thomas> In-Reply-To: <1649649325-1942-1-git-send-email-chcchc88@163.com> References: <1647918560-14165-1-git-send-email-chcchc88@163.com> <1649649325-1942-1-git-send-email-chcchc88@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/04/2022 05:55, Huichao Cai: > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting process.Add some test data for the IPv4 header optional > field fragmenting. > > Signed-off-by: Huichao Cai You forgot the ack given on v5: Acked-by: Konstantin Ananyev Applied, thanks.