DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment
@ 2014-10-30  3:40 Matthew Hall
  2014-10-30  9:57 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Hall @ 2014-10-30  3:40 UTC (permalink / raw)
  To: dev

Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 5fe3961..ddb0535 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 	snprintf(filename, sizeof(filename), "%s/numa_node",
 		 dirname);
 	if (access(filename, R_OK) != 0) {
-		/* if no NUMA support just set node to 0 */
+		/* if no NUMA support just set node to -1 */
 		dev->numa_node = -1;
 	} else {
 		if (eal_parse_sysfs_value(filename, &tmp) < 0) {
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment
  2014-10-30  3:40 [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment Matthew Hall
@ 2014-10-30  9:57 ` Bruce Richardson
  2014-11-05 21:52   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2014-10-30  9:57 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

On Thu, Oct 30, 2014 at 03:40:08AM +0000, Matthew Hall wrote:
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 5fe3961..ddb0535 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
>  	snprintf(filename, sizeof(filename), "%s/numa_node",
>  		 dirname);
>  	if (access(filename, R_OK) != 0) {
> -		/* if no NUMA support just set node to 0 */
> +		/* if no NUMA support just set node to -1 */
>  		dev->numa_node = -1;
>  	} else {
>  		if (eal_parse_sysfs_value(filename, &tmp) < 0) {
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment
  2014-10-30  9:57 ` Bruce Richardson
@ 2014-11-05 21:52   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-11-05 21:52 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-05 21:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-30  3:40 [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment Matthew Hall
2014-10-30  9:57 ` Bruce Richardson
2014-11-05 21:52   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git