* [PATCH] examples/flow_classify: fix spelling when log error
@ 2022-01-18 2:49 Chuanshe Zhang
2022-02-23 16:05 ` Iremonger, Bernard
0 siblings, 1 reply; 4+ messages in thread
From: Chuanshe Zhang @ 2022-01-18 2:49 UTC (permalink / raw)
To: dev; +Cc: bernard.iremonger
Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
---
examples/flow_classify/flow_classify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c
index 6185b34..97708b7 100644
--- a/examples/flow_classify/flow_classify.c
+++ b/examples/flow_classify/flow_classify.c
@@ -430,7 +430,7 @@ struct rte_flow_query_count count = {
&ntuple_filter->dst_ip,
&ntuple_filter->dst_ip_mask);
if (ret != 0) {
- flow_classify_log("failed to read source address/mask: %s\n",
+ flow_classify_log("failed to read destination address/mask: %s\n",
in[CB_FLD_DST_ADDR]);
return ret;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] examples/flow_classify: fix spelling when log error
2022-01-18 2:49 [PATCH] examples/flow_classify: fix spelling when log error Chuanshe Zhang
@ 2022-02-23 16:05 ` Iremonger, Bernard
2022-03-08 11:43 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Iremonger, Bernard @ 2022-02-23 16:05 UTC (permalink / raw)
To: Chuanshe Zhang, dev
Hi Chuanshe,
> -----Original Message-----
> From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> Sent: Tuesday, January 18, 2022 2:50 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] examples/flow_classify: fix spelling when log error
>
> Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> ---
> examples/flow_classify/flow_classify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/flow_classify/flow_classify.c
> b/examples/flow_classify/flow_classify.c
> index 6185b34..97708b7 100644
> --- a/examples/flow_classify/flow_classify.c
> +++ b/examples/flow_classify/flow_classify.c
> @@ -430,7 +430,7 @@ struct rte_flow_query_count count = {
> &ntuple_filter->dst_ip,
> &ntuple_filter->dst_ip_mask);
> if (ret != 0) {
> - flow_classify_log("failed to read source address/mask:
> %s\n",
> + flow_classify_log("failed to read destination address/mask:
> %s\n",
> in[CB_FLD_DST_ADDR]);
> return ret;
> }
> --
> 1.8.3.1
/dpdk_22_03/devtools# ./checkpatches.sh examples-flow_classify-fix-spelling-when-log-error.patch
### [PATCH] examples/flow_classify: fix spelling when log error
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
/dpdk_22_03/devtools# ./check-git-log.sh -1
Missing 'Fixes' tag:
examples/flow_classify: fix spelling when log error
Otherwise, the fix looks good.
Regards,
Bernard.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] examples/flow_classify: fix spelling when log error
2022-02-23 16:05 ` Iremonger, Bernard
@ 2022-03-08 11:43 ` Thomas Monjalon
2022-03-08 12:00 ` Iremonger, Bernard
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2022-03-08 11:43 UTC (permalink / raw)
To: Chuanshe Zhang; +Cc: dev, Iremonger, Bernard
23/02/2022 17:05, Iremonger, Bernard:
> Hi Chuanshe,
>
> From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> >
> > Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > ---
> > - flow_classify_log("failed to read source address/mask:
> > %s\n",
> > + flow_classify_log("failed to read destination address/mask:
> > %s\n",
>
> ### [PATCH] examples/flow_classify: fix spelling when log error
> WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
>
> /dpdk_22_03/devtools# ./check-git-log.sh -1
> Missing 'Fixes' tag:
> examples/flow_classify: fix spelling when log error
>
> Otherwise, the fix looks good.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] examples/flow_classify: fix spelling when log error
2022-03-08 11:43 ` Thomas Monjalon
@ 2022-03-08 12:00 ` Iremonger, Bernard
0 siblings, 0 replies; 4+ messages in thread
From: Iremonger, Bernard @ 2022-03-08 12:00 UTC (permalink / raw)
To: Thomas Monjalon, Chuanshe Zhang; +Cc: dev
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, March 8, 2022 11:44 AM
> To: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [PATCH] examples/flow_classify: fix spelling when log error
>
> 23/02/2022 17:05, Iremonger, Bernard:
> > Hi Chuanshe,
> >
> > From: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > >
> > > Signed-off-by: Chuanshe Zhang <zhangchuanshe@icloudshield.com>
> > > ---
> > > - flow_classify_log("failed to read source address/mask:
> > > %s\n",
> > > + flow_classify_log("failed to read destination address/mask:
> > > %s\n",
> >
> > ### [PATCH] examples/flow_classify: fix spelling when log error
> > WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> > appropriate one
> >
> > /dpdk_22_03/devtools# ./check-git-log.sh -1 Missing 'Fixes' tag:
> > examples/flow_classify: fix spelling when log error
> >
> > Otherwise, the fix looks good.
>
> Applied, thanks.
>
You can add my ack to this patch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-08 12:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 2:49 [PATCH] examples/flow_classify: fix spelling when log error Chuanshe Zhang
2022-02-23 16:05 ` Iremonger, Bernard
2022-03-08 11:43 ` Thomas Monjalon
2022-03-08 12:00 ` Iremonger, Bernard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).