From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 5AB4EBB86 for ; Wed, 26 Oct 2016 17:20:21 +0200 (CEST) Received: by mail-lf0-f53.google.com with SMTP id t133so8539968lff.6 for ; Wed, 26 Oct 2016 08:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=SN3eLY5ROs7LQN9h+g1JB4q3aVvCQBoICaWGN7qjGaA=; b=L9ryUlpPzygBQZE0HQSlh9IkIH8Lv9QGjgitKmmGebpnoN/qYfekjNEL33P0Ra7kDU r6EOqj5R8UPl/zJIwpKayn4GYVk+wP6dd3jUPp2VJPmlsEMkT3M8SKkNsubB+b2c00aJ 55TOCqLuE+xgFmNT8eNQckLQkmlB6bhpdym5SxDMhPNZ+N1G7IHjDkcSYsSevoWSrhjH dUm3ydi3fVCe4VhlkJa+aVhs5+jI2D2Th0l+YeW2hpZXIfiAzZ7D5QgvPUVJqnR9lJNn 0BiXXlkEX6f4mthr65EvpO8hxUPzQNiRNMwAPPhjRdf18xIGj6rfn427phE5GpwKFtwJ ixhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=SN3eLY5ROs7LQN9h+g1JB4q3aVvCQBoICaWGN7qjGaA=; b=KsI6NpLXHNJtY0G2yyPf93Ag8gOU/+U/SyhgepjlmIcoP9WUpoU+K1yYVqxUzeEoNk 3PcprbdB32KS49fi4inOvoCx3XF5l4jJnlWFzLiQjcC0fOCdu56j3l+Jxv9q+DknRmLM a2x2qpI1E27HI0zJHHsTDkjRsFEd9VCwIDVWjfYGe7rVC7OUD9gmZuw6TUAhjGYl0Nu5 2OHT4ZhEFxLi3KhZnwSSYaJgQqwIn9yxqRnbCqyIgDFhXh8sRbiwLOkTcdY1sT3At1Gx ubPqypY730m2r6KlSoox1v/44bgLgDnGn2MrVPknRoHMGijHrLg+XKEPHZzcCTOOTyei 9hOw== X-Gm-Message-State: ABUngvdFDELNBIiO4YjLDNS4PLH9nzgSpKIt+6ETp3wmrdb/uX8hZw7Kq6HSNd0G7UZ+zHLk X-Received: by 10.194.87.170 with SMTP id az10mr2994396wjb.189.1477495220922; Wed, 26 Oct 2016 08:20:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id au8sm3196407wjc.12.2016.10.26.08.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 08:20:20 -0700 (PDT) From: Thomas Monjalon To: Rasesh Mody Date: Wed, 26 Oct 2016 17:20:18 +0200 Message-ID: <39933081.0D9pxCKPPb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161024134150.GB27760@bricha3-MOBL3.ger.corp.intel.com> References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <20161024134150.GB27760@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, ferruh.yigit@intel.com Subject: Re: [dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 15:20:21 -0000 2016-10-24 14:41, Bruce Richardson: > On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote: > > Please apply to DPDK tree for v16.11 release. > > Patchset applied to dpdk_next_net/rel_16_11 It breaks compilation because it is enabled everywhere and zlib.h is still included without checking CONFIG_ECORE_ZIPPED_FW. The patch removing zlib dependency was not tested without zlib installed. I will fix it while applying with this change: --- a/drivers/net/qede/base/bcm_osal.c +++ b/drivers/net/qede/base/bcm_osal.c @@ -6,7 +6,9 @@ * See LICENSE.qede_pmd for copyright and licensing details. */ +#ifdef CONFIG_ECORE_ZIPPED_FW #include +#endif #include #include I won't do any quality review of qede patches but from what I've seen before, there is some room for improvements. Another nit, important to help reviews, please use --in-reply-to when sending a new revision of a patch to keep them in the same thread and allow us to understand the progress. I plan to do an automatic nack for patches missing the --in-reply-to.