From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id A793C8093 for <dev@dpdk.org>; Fri, 12 Dec 2014 16:10:12 +0100 (CET) Received: by mail-wg0-f54.google.com with SMTP id l2so9349850wgh.13 for <dev@dpdk.org>; Fri, 12 Dec 2014 07:10:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3/BctiZq0xZ72l77B3U5CXKbgQuJpPAbU7v5XwDoLM8=; b=ZqgjkVz+zYC+9N/4NGJZx+mjP4a5kuUAjPNN0vT5pjVpZtIUcc2M9DbHyiukygYntJ h+VHGQ8Ska3fZjmH0iO6MP7Qe1X5Uq4kvtFyFxgPqSQKDpaF0zfljacbW2v1wKMRaIKA GKFUoYrkXqqItjLvnYhNvQGa4O5ZXyN4fPVKVp0KMDa0Feyljb0mu2zc5jvEZfpft4mg sgJ2mL1+aBLl+OLP+mSTyHL5sLv884FrhKmHtYF1IwdoW3Gd9vvHHAX7yw2mNvsWcxej p3HDkyHecg+Hh1epwajprAbKdr+sVGDoA1AA9IXjZNv9drciuo7UZFMfBA4+WtA8StKZ BNJA== X-Gm-Message-State: ALoCoQm3UvG5LAJPVnGou3kxpTCk/grRSIRX69bA2MkeoV+hZpjogmxAUEOM7xL747rvs4kLW+QC X-Received: by 10.180.103.229 with SMTP id fz5mr8601732wib.31.1418397012131; Fri, 12 Dec 2014 07:10:12 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id be4sm2287951wib.16.2014.12.12.07.10.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Dec 2014 07:10:11 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Neil Horman <nhorman@tuxdriver.com> Date: Fri, 12 Dec 2014 16:09:46 +0100 Message-ID: <3996083.nXet19ofoo@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141212113824.GA14102@hmsreliant.think-freely.org> References: <1417684369-21330-1-git-send-email-michael.qiu@intel.com> <9863237.MyFdkOxhYo@xps13> <20141212113824.GA14102@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2 v4] Fix two compile issues with i686 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 12 Dec 2014 15:10:13 -0000 2014-12-12 06:38, Neil Horman: > On Thu, Dec 11, 2014 at 10:21:44PM +0100, Thomas Monjalon wrote: > > 2014-12-11 15:28, Qiu, Michael: > > > On 2014/12/11 21:26, Neil Horman wrote: > > > > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: > > > >>> These two issues are both introuduced by commit b77b5639: > > > >>> mem: add huge page sizes for IBM Power > > > >>> > > > >>> Michael Qiu (2): > > > >>> Fix compile issue with hugepage_sz in 32-bit system > > > >>> Fix compile issue of eal with icc compile > > > >> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > > >> > > > >> Applied > > > >> > > > >> Thanks > > > >> > > > > Wait, why did you apply this patch? We had outstanding debate on it, and > > > > Michael indicated he was testing a new version of the patch. > > > > > > Yes, I test the solution you suggest :) and it mostly works, but with a > > > little issue. > > > I have re-post not the old version. > > > > Neil, v4 is a new version implementing what you suggested. > > There was no comment and it looks good so I applied it. > > > > > Do you take a look at? > > > I didn't. Apologies, I see the v4 now. That said, something is off. If you > look at the list archives, I see patch 0/2 v4 in the list, but not 1/2 or 2/2, > theres no actual patch that got posted. Was it sent to you privately? No there are public and you are Cc. > > I think Neil missed the v4. Sorry to not have pinged you, I wanted rc4 for > > validation at this time. > > Neil do you agree this version is OK or do you see some issue to fix? > > > Again, I think Michales send went sideways. 0/4 went to the list but the actual > patches only went to you Thomas. Please post them to the list They were correctly posted: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/9282/focus=9754 -- Thomas