From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 167C42B87 for ; Wed, 27 Feb 2019 09:31:22 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 291B1787EF; Wed, 27 Feb 2019 08:31:22 +0000 (UTC) Received: from [10.36.112.64] (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1D345C6AF; Wed, 27 Feb 2019 08:31:20 +0000 (UTC) To: Dariusz Stojaczyk , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: Darek Stojaczyk References: <20190224233555.31304-1-darek.stojaczyk@gmail.com> From: Maxime Coquelin Message-ID: <39ad2842-9763-1521-089d-2cd2e98d9f08@redhat.com> Date: Wed, 27 Feb 2019 09:31:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190224233555.31304-1-darek.stojaczyk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 27 Feb 2019 08:31:22 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: remove vhost-net requirements from generic vhost APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 08:31:23 -0000 On 2/25/19 12:35 AM, Dariusz Stojaczyk wrote: > From: Darek Stojaczyk > > The rte_vhost API to put data into virtqueues operates > on mbufs and hence it is strictly vhost-net specific. > External backends need to implement virtqueue handling > from scratch and that's just not possible without APIs > to get/set vring base addresses. > > Those relevant APIs are there, but they have a check that > prevents them from working with any non-vhost-net device. > This patch removes those checks. > > rte_vhost_get_log_base() is not necessarily needed for > external backends, as other, higher level vhost APIs for > live migration are available and could be used instead. > We remove the extra check from it anyway for consistency. > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_vhost/vhost.c | 21 --------------------- > 1 file changed, 21 deletions(-) > Applied to dpdk-next-virtio/master. Thanks, Maxime