From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88841A0524; Mon, 31 May 2021 12:23:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7494640140; Mon, 31 May 2021 12:23:40 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id DD3144003F for <dev@dpdk.org>; Mon, 31 May 2021 12:23:38 +0200 (CEST) IronPort-SDR: b/MwDsv3NzulAHNkxA2x0xMyUv3wW88xecIn72uZJe0QPlGEcExhqFGIKGN6/pCgTalGQS9mKq KG2Ip7fG8uBw== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="203338316" X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="203338316" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2021 03:23:37 -0700 IronPort-SDR: VIluRlJUcf8LOObW/zEVIrp02saFw6XLnhYHqKHMo+E0e6zRSK5KTrLHSwokxGAOGv2Ji9FgGh Jmwe3HnVFO+Q== X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="478862539" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.25.241]) ([10.252.25.241]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2021 03:23:36 -0700 To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org Cc: stephen@networkplumber.org, Richael.Zhuang@arm.com, reshma.pattan@intel.com References: <2fae7084c99dc8223e8d3a0aa9c2e5ba18bf1e6b.1619104102.git.anatoly.burakov@intel.com> <a3d905e76229e2f77a164379af8ccb0dcdac0dbc.1619175790.git.anatoly.burakov@intel.com> From: David Hunt <david.hunt@intel.com> Message-ID: <39da6764-4abe-4b68-59d5-fb15c8d339aa@intel.com> Date: Mon, 31 May 2021 11:23:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <a3d905e76229e2f77a164379af8ccb0dcdac0dbc.1619175790.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [21.08 PATCH v4 1/2] power: don't use rte prefix in internal code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Anatoly On 23/4/2021 12:03 PM, Anatoly Burakov wrote: > Currently, ACPI code uses rte_power_info as the struct name, which > gives the appearance that this is an externally visible API. Fix to > use internal namespace. > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> > --- > lib/power/power_acpi_cpufreq.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > Looks good. This brings the acpi driver code in line with the pstate driver code, which already has it's struct called ptate_power_info. Acked-by: David Hunt <david.hunt@intel.com>