From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0086.outbound.protection.outlook.com [104.47.41.86]) by dpdk.org (Postfix) with ESMTP id 11E651B651 for ; Mon, 16 Oct 2017 13:26:59 +0200 (CEST) Received: from BN6PR03CA0010.namprd03.prod.outlook.com (10.168.230.148) by CO2PR03MB2360.namprd03.prod.outlook.com (10.166.93.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 11:26:58 +0000 Received: from BL2FFO11FD044.protection.gbl (2a01:111:f400:7c09::130) by BN6PR03CA0010.outlook.office365.com (2603:10b6:404:23::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Mon, 16 Oct 2017 11:26:57 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD044.mail.protection.outlook.com (10.173.161.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Mon, 16 Oct 2017 11:26:57 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9GBQsr5022881; Mon, 16 Oct 2017 04:26:55 -0700 To: Gaetan Rivet References: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> From: Shreyansh Jain CC: Message-ID: <39e734ea-531c-6335-f1d5-22c75fe38f9e@nxp.com> Date: Mon, 16 Oct 2017 17:09:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131526268177555796; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(377454003)(189002)(58126008)(77096006)(33646002)(65956001)(65806001)(23676002)(47776003)(105606002)(316002)(230700001)(68736007)(85426001)(2950100002)(498600001)(229853002)(65826007)(50466002)(6916009)(83506001)(106466001)(8936002)(31686004)(6246003)(189998001)(5660300001)(2906002)(53936002)(54356999)(81156014)(81166006)(356003)(76176999)(50986999)(8676002)(36756003)(575784001)(86362001)(104016004)(31696002)(6666003)(97736004)(64126003)(305945005)(69596002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2360; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD044; 1:qVQsEZsn/GkSohhG088WO46nS/Nr4uTKF2r0e3OD0CoLDKtNgSrx8Nyyj2eWa08IBppGfc1hOdWpq6ZpoRMwQRtcXKZliuOx+K8BMb/HPT2L9hd4rJmD9kLdTbOu8Hm7 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bd41574-09ec-430f-2154-08d51488cfd2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2360; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 3:WS5Uv1ZtXCP+LFbMnYud32n/8/+6jxF7NZ4OT0cjCywOLpmhkIxUUvC5bcuZHqA1uX6RMVB2zfx3DDeELw48LrB5YTvxpmEhXEaKWkPMdgsnMbxSdel/oRGiFHAH704h7NlAHEP8sYWSAOEiiEtW4YMq5YjEKJVrrp/+/k5Fsb49r4oU5K1/duXdFVIkFEdRog4WVX3VQaDi5BfT3RE/YV6BRz9oh1MHWEGT++3PZkubCiXXXW17F4aOJHPxNubHE9CA/9nalnT8nRouboBT76mlweJd/8euAfX4cHdhkcjECJ+3lB1vlPIVEGHLPExkgBZkeiLdplRoBQ+AMo0cAGhKgY/T7gVQih5K9ddcvSM=; 25:6WOahvhQKyCnSQcSFHweioRmfzWZ0LM02QD1jLAdG7bWbBX/l8qlmKCh3f8Dd5k3x97EJv5qEGezKslV4equ4G+mcguPMPfaUXTatKi0+Mt5I0eVaiD94yO9ozc9I6tvV8t2v5rAK3bdd96MVTuuYq1FMClE7MXnKYFJzpqulv3rHU8Lq8Z3iD2NS7X9LIQ9kmQrtk0Xj74H6KiOVVi9TWLhjc0UDR2B6GbkElkdpDNe9kYpKGpjwOTHzMq4knXkEtRwBdIBnxmin3F5mCDMXNiiU6Yk6jIash79pPq4pJt0iy9x11ByE9C7mFtva0OOCPLMQG4w78v00oIn3/ixATK0XIdUZRdEUmaQ2yxHJN8= X-MS-TrafficTypeDiagnostic: CO2PR03MB2360: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 31:2ElQTfxkAiSi60TtUgD4L3ZcM41TGvdpSed71UW+LQersDZGSLgLfk1KM/JQX/8XHGk8xzf1VRAeuKtoBvzzhrzx/2HifJ+ZVCl3FJGiMmw1dquzLg2dJl7cigmZmgMrdLLOSbVbi9N8/3IkSiSkLQ/XCv1cbSAGyiUdPl4DlQ3EJobHc+tJ03PMgxkiwkGIzB7kxUWo0AJSZydJAs6QAAS6CPXZzlv19v2rtXtdCJ4=; 4:KtFOMu9+pjc6d7Wgk0C2LQKo4wGPyxWEbqcndgDxvPvgyUDyyIajfomNSzB2VIhDghvfZcttoGil1VcvL6YntGSMy92oEPxBDj+0r8Bb3Wn/Z5Tz1jClZQYaUdg+Aq6J5LvxNxrGLgbVZPP7vWX7xdWGzoEK81PHr6QIXMwcwxOuU+Uqcd0Zh1IN11LGFjgZjqbZrhqdvyjO1MLdE0mCSHny1Y5i3havnPHd+DmU5/2M8GDAHr2wnoCmGEs9mu/C X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123556025)(20161123559100)(20161123561025)(20161123563025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2360; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2360; X-Forefront-PRVS: 0462918D61 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzYwOzIzOjlqVkh6U05KT3RYM1FkWmdubmVPYkFYNFhO?= =?utf-8?B?bVdsT3RRVk9VYVo1VjdxZ3BxdlhuYXlrMnd2Mlp0S3EzZWZ0OFpRQ0RPaGVG?= =?utf-8?B?Y2g0TEUxcERXbG96SGpjcUFSSVJuczVyRmxjZGVEZjJ5UFJZSlZ6L0lzaytQ?= =?utf-8?B?MzJIb21SandWaGhVbExVWWZNS2c3SFgxbnB0Sko5bWFMMzF3aUtYSDZhaHVD?= =?utf-8?B?VXZqN2Q0L2UydGwwWmdJYlpINThzY1JCYnNHZThabXo3VHVua3g2Z1p3SHBN?= =?utf-8?B?MnJwdkxwM3RPak52NkNQcm1TaGlJckFHVnBCZnBEUzdocHQxeHY4S2JWWmx1?= =?utf-8?B?dG1SUENLekdXdHpNNDhqMlBwTnM2T0x6cUpycTVMVDM1cFRiZ1R1N05SVUU0?= =?utf-8?B?SEpDTml3eDJFbmVaVFRFWjRpWmtIaEU3VHJmdkxWaE9sSklvUnovbWNKQ1RL?= =?utf-8?B?NlRHN1FGYkNaVjhEdGZ5dS96V0xOa2V0MlZqRzVhRHdPK3l2MnorMzZkQ1lX?= =?utf-8?B?bVpWait6dFN1bjBYVXZ3UFdvV1Y3MG8rekNVekt3aUU1bDUvV2p4UEltb21v?= =?utf-8?B?K2pYNllHajhWQTl4TGIxZWJ2RlpwRENZVFM2M09mWVlOUjZ6V1RBNDlFSE1R?= =?utf-8?B?WUxVVnpUeUZYYmVlRWx1N1ROS0xHUXNuMDFvanVXTytlM0crZnl6cWtZNHFz?= =?utf-8?B?R3NteFFadGpIQUkyU05nNFBXdmNDcnR3Qmt3V0RreHlqK2hadCs2cW5rNXFz?= =?utf-8?B?M1UzU2RhQ2tIVVV3My9tSGJCc3JPd0x1Q0NCTEFCUEUrVzBpUEo1RCtjR0xS?= =?utf-8?B?RWhQZmhXd1N5OGYvRUVGS2V6QkxCN1Niak1sZnJnNVc5RjZoeFJNLzhpK1Ju?= =?utf-8?B?VWhUYTA2SitvU1BkNlBhUlIzOUlSZFF1MUFvVi9rTE04aytjNzJtcjlHWFZ2?= =?utf-8?B?NWdSTEVsaVhpL1RwUnY0VEZQNWY2TlY0V1lLZHpxeG1xbUxtYVpLRFhXa01n?= =?utf-8?B?SHBkZTh3eU52S3RpZkJWL096TEswRnE4bCsvUE8rMjdGTS8wT1AwNllLYWRh?= =?utf-8?B?K0F3VmpTRmtFV0dBMk9LdTUyT3ZCRWpINXF4b3pTT1dLcDVSV2FXTCtGdmFv?= =?utf-8?B?OFlhNVpESUxZdjFEbEQ4WFNWOEtxVnIwYmxlWnpJNlNzblVyalpMUmRZTUZO?= =?utf-8?B?NWpHSm9ncDJ1TDlWZzFGRDNTb3o3akxqSk94NjVxYnN5WlZOVGtmUEs2cVUx?= =?utf-8?B?RHluUnczQUR1a3dGRytJbXhNNUhFU2xlQktVUGxIVDhMdkpSOFBnUlNyQlVo?= =?utf-8?B?Y244VVRLd1g0TnVrUFV3L1Z1UnJNUTdxQXhFeU00ZllMeTl5TEVBZFZwY1pF?= =?utf-8?B?Y3ZxMmN2aXJsOWZFKytzdEsrVlZ3bE1QNFlKbkNiYTV6OElPVTNoSUVSaTNW?= =?utf-8?B?VFlJTUpvcDNvYmRjbnppQ3hSS2tnR3hEWHU5czA5eDJRcVovSnR3NGF2UURH?= =?utf-8?B?MkJUd2ZpZTBpZTVZWVk4WEtZeHMycVI0UG1mb1lEZEpPcEhya24ydlZ4SXBl?= =?utf-8?B?NlpYVmNvNS82aTJRb2Z6RDh3ZkhkemVFRktIUUllTnZJNkpWa1UvZ045dUJJ?= =?utf-8?B?OXhDTFczOU01VW9TV3k5ZWVvQjhFZkc3S0VQSUdOQVBKalNWZ01MWGFXWUUz?= =?utf-8?B?MGwyMjc5THJxQ1Y2cS85K0FHMk5iYlpHUGxrYWlGZjFSeXdvNEk1WlBoRmJC?= =?utf-8?B?QktJNFJXbHNjSW5paCtIUHMxZHFyaW54ckVacS9HOGlqR2NLSWw1NmtBaXN3?= =?utf-8?B?QUJ5NFNPVDNXWjZ1V0ZzUExhM1FyTmNXcDJGQnhIUVZMWmZlbkRwMHNPVTlq?= =?utf-8?Q?GwkNI5sCnAc=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 6:yNkjJg8nRJTDRj1r2zTehB35lioUiwVlDLzvOkHDfE4TaFsBo1SM3noqNCWkH7T0sHZog5aGofv0V9XdyxIx8ywGfMlpiIIoGAeT+WwzA7OerwIM6Kh29tod/aMpTFXmD6lW6qsIIvwABF//5P6TQDJrg6+Y5Rwl/pgGRciyeiBKfyK8zoDK3k/IY0k1zEMsHoKaGOh8EoSvO9cMh6sZ00Iit1GoWQSmqFuPIjU3B6/woBEwUwNTSjciOoT3LnOw8XGF1z3SKryJPvwv0L/EYxl+oU2F5hU9xf/oSILSUz5lkg0j/ZoOo2b9eZTA8AY8gGeAVAM0+hq6K2qwGsMT1w==; 5:lP0xkup3Y9NIWDsOoZ0nnoCBTbnrJy6iiuQZPhKH0La3kPxcd8Zb81egSt3r6i3eval4yHE8a18XOrdaRTShTd1sGrxaktbi0ECTNO8lek3vabBfLDU30LEU9Jvq3fU4MYacRgX2dfYcAmA39T5QwqwXkFpuVNDEUxStZshSjRc=; 24:8QOB5rgSUSqUkvuMoKWZNnopoVISdev1YD0rbngqIIFR9JBJkok3xwPV+A/7qGBUItAeTa7rxLL9thQXu972rZhqNzD+jsFBTREcj5xY9wA=; 7:1fidYcJoeOpYQIGnv+NjJWloJmzHEPX7c26k77TZnFu2BQSu+CIZ95fuO4BlYjcPKU52Yi96BvnmklebF3srXWGkpJJuBIXt75JrVel3g+GU0KLxaW7sFdxVwir/sC+OixTLFCdFGcRQaNhlv6gfN968LSwK6M1RmHoRy1dlr37MLj6z5HQWArBwvI4rghSN2kQwhbRkQSuN9btNcvL++beFC8vcZ7gWt2RFxFm/dlc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 11:26:57.5059 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2360 Subject: Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 11:27:00 -0000 Hello Gaetan, On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: > Re-use existing code, remove incorrect comments. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_devargs.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c > index 49cc3b8..1d87cd9 100644 > --- a/lib/librte_eal/common/eal_common_devargs.c > +++ b/lib/librte_eal/common/eal_common_devargs.c > @@ -153,21 +153,19 @@ rte_eal_devargs_insert(struct rte_devargs *da) > return 0; > } > While trying to work on this patch, I noticed that the complete series (including "Move PCI away from EAL") is not cleanly applicable on current master (17.11 RC1). I thought it would be some tiny issues. But there are some issues which I couldn't pass, Like... > -/* store a whitelist parameter for later parsing */ > int In the this function > -rte_eal_devargs_add(const char *devargs_str) > +rte_eal_devargs_add(const char *dev) > { > struct rte_devargs *devargs = NULL; > - const char *dev = devargs_str; > > - /* use calloc instead of rte_zmalloc as it's called early at init */ > devargs = calloc(1, sizeof(*devargs)); > if (devargs == NULL) > goto fail; > > if (rte_eal_devargs_parse(devargs, "%s", dev)) > goto fail; These lines don't exist in your patch --- 59c2ba6c 172) if (bus->conf.probe_mode == RTE_BUS_PROBE_UNDEFINED) { b631f3b0 173) if (devargs->policy == RTE_DEV_WHITELISTED) 59c2ba6c 174) bus->conf.probe_mode = RTE_BUS_PROBE_WHITELIST; b631f3b0 175) else if (devargs->policy == RTE_DEV_BLACKLISTED) 59c2ba6c 176) bus->conf.probe_mode = RTE_BUS_PROBE_BLACKLIST; 02823c1d 177) } bf6dea0e 178) TAILQ_INSERT_TAIL(&devargs_list, devargs, next); bf6dea0e 179) return 0; 0215a4c6 180) --- (Some introduced by the move PCI series, but others like b631f3b0 are very old ~17.08) > - TAILQ_INSERT_TAIL(&devargs_list, devargs, next); > + if (rte_eal_devargs_insert(devargs)) > + goto fail; And hence, I don't know whether you intend to insert the above line after or before checking PROBE. > return 0; > > fail: > Maybe I am doing something wrong here - any ideas? Can you send an updated/rebased version on current master HEAD? - Shreyansh