From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO
Date: Mon, 16 Apr 2018 11:09:14 +0100 [thread overview]
Message-ID: <39e7d9f7-43d9-39be-7a6f-d17d0b9042b5@intel.com> (raw)
In-Reply-To: <DB7PR05MB4426308F57ACAFBAE9FB2741C3B00@DB7PR05MB4426.eurprd05.prod.outlook.com>
On 16-Apr-18 6:50 AM, Shahaf Shuler wrote:
> Friday, April 13, 2018 4:59 PM, Thomas Monjalon:
>>>
>>> OK. Shahaf, will you submit a v2 with this, or should i do it? I think
>>> it should be just a matter of #ifndef VFIO_PRESENT //define
>>> vfio_device_info struct #endif - this should take care of the problem
>>> of hiding the function definitions.
>>>
>>> FreeBSD will also need to be adjusted to remove dummy prototypes.
>>
>> I think you are more familiar with VFIO than any of us.
>> It is better to let you do, think about the implications and do the tests.
>> Thanks :)
>>
>
> I don't mind whom of us will do it, as long as it will be done quickly. Currently there are some tests which cannot run on our regression due to it.
>
>
Yes, i'll be submitting the patch shortly.
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-04-16 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 13:34 Shahaf Shuler
2018-04-12 14:13 ` Burakov, Anatoly
2018-04-12 23:39 ` Thomas Monjalon
2018-04-13 9:11 ` Burakov, Anatoly
2018-04-13 13:08 ` Thomas Monjalon
2018-04-13 13:37 ` Burakov, Anatoly
2018-04-13 13:58 ` Thomas Monjalon
2018-04-16 5:50 ` Shahaf Shuler
2018-04-16 10:09 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e7d9f7-43d9-39be-7a6f-d17d0b9042b5@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).