From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6B13B1B021 for ; Mon, 16 Apr 2018 12:09:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 03:09:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="48223848" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga001.jf.intel.com with ESMTP; 16 Apr 2018 03:09:15 -0700 To: Shahaf Shuler , Thomas Monjalon Cc: "dev@dpdk.org" References: <20180412133422.104155-1-shahafs@mellanox.com> <23085973.mySOohilc8@xps> <507876726.mBf8imolCA@xps> From: "Burakov, Anatoly" Message-ID: <39e7d9f7-43d9-39be-7a6f-d17d0b9042b5@intel.com> Date: Mon, 16 Apr 2018 11:09:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 10:09:17 -0000 On 16-Apr-18 6:50 AM, Shahaf Shuler wrote: > Friday, April 13, 2018 4:59 PM, Thomas Monjalon: >>> >>> OK. Shahaf, will you submit a v2 with this, or should i do it? I think >>> it should be just a matter of #ifndef VFIO_PRESENT //define >>> vfio_device_info struct #endif - this should take care of the problem >>> of hiding the function definitions. >>> >>> FreeBSD will also need to be adjusted to remove dummy prototypes. >> >> I think you are more familiar with VFIO than any of us. >> It is better to let you do, think about the implications and do the tests. >> Thanks :) >> > > I don't mind whom of us will do it, as long as it will be done quickly. Currently there are some tests which cannot run on our regression due to it. > > Yes, i'll be submitting the patch shortly. -- Thanks, Anatoly