From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 817B444103;
	Wed, 29 May 2024 17:59:22 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5FE8940273;
	Wed, 29 May 2024 17:59:22 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id E24064026F
 for <dev@dpdk.org>; Wed, 29 May 2024 17:59:20 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5738E339;
 Wed, 29 May 2024 08:59:44 -0700 (PDT)
Received: from [10.1.25.43] (FVFG51LCQ05N.cambridge.arm.com [10.1.25.43])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4949D3F792;
 Wed, 29 May 2024 08:59:19 -0700 (PDT)
Message-ID: <39ebf4c1-e4d2-4167-8c4e-5af101883f05@arm.com>
Date: Wed, 29 May 2024 16:59:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/8] dts: add testpmd shell params
Content-Language: en-GB
To: Jeremy Spewock <jspewock@iol.unh.edu>
Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, 
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240326190422.577028-1-luca.vizzarro@arm.com>
 <20240509112057.1167947-1-luca.vizzarro@arm.com>
 <20240509112057.1167947-6-luca.vizzarro@arm.com>
 <CAAA20UTBUwZephc-0s+Bpcv1UqSs6D1VDyUo6D3o=7R-qrmUwA@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAAA20UTBUwZephc-0s+Bpcv1UqSs6D1VDyUo6D3o=7R-qrmUwA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 28/05/2024 22:05, Jeremy Spewock wrote:
> This looks good, the only comment I had was in some classes the
> docstrings didn't get updated to what was discussed previously in the
> comments (making sure the comments are included in the class'
> docstring). I tried to point out a few places where I noticed it.

Apologies for asking again, as I may have totally missed them. Would you 
be able to clarify or give examples to what you are referring to exactly?

Will update the docstring format for the Enum class members.