From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 121447EF0 for ; Mon, 16 May 2016 12:24:48 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 16 May 2016 03:24:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,626,1455004800"; d="scan'208";a="807546755" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 16 May 2016 03:24:46 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.120]) by IRSMSX106.ger.corp.intel.com ([169.254.8.131]) with mapi id 14.03.0248.002; Mon, 16 May 2016 11:24:46 +0100 From: "Pattan, Reshma" To: Simon Kagstrom , "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues Thread-Index: AQHRr1YcbhooDAHe40O3UEUsiK4NyZ+7U93g Date: Mon, 16 May 2016 10:24:45 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F0102622D@IRSMSX109.ger.corp.intel.com> References: <20160516113349.7d2a992f@miho> In-Reply-To: <20160516113349.7d2a992f@miho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDA4ODc3Y2MtMzlhZi00N2ZiLTgyOTktMWExOTExZGZiYzY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvTVFGSnV3UzUzamdBSmM1U0JnTFBxNTk5VlR0MXF3TEhsWmxtTGM0QVwvUT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 10:24:49 -0000 > -----Original Message----- > From: Simon Kagstrom [mailto:simon.kagstrom@netinsight.net] > Sent: Monday, May 16, 2016 10:34 AM > To: dev@dpdk.org; thomas.monjalon@6wind.com; Pattan, Reshma > > Subject: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/= TX > queues >=20 > This allows releasing RX/TX queue memory. > --- >=20 > Without this patch, this explicitly isn't allowed. Is there a particular = reason why it > shouldn't? It was introduced in >=20 > d505ba80a165a9735f3d9d3c6ab68a7bd85f271b >=20 > "ethdev: support unidirectional configuration" >=20 > lib/librte_ether/rte_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c index > a31018e..5481d45 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -944,11 +944,6 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t > nb_rx_q, uint16_t nb_tx_q, > */ > (*dev->dev_ops->dev_infos_get)(dev, &dev_info); >=20 > - if (nb_rx_q =3D=3D 0 && nb_tx_q =3D=3D 0) { > - RTE_PMD_DEBUG_TRACE("ethdev port_id=3D%d both rx and tx > queue cannot be 0\n", port_id); > - return -EINVAL; > - } > - This was added to allow devices, at least with one direction (RX/TX) supp= orted. As, devices with both directions disabled doesn't make sense right? Thanks, Reshma