From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D6C14ADC5 for ; Fri, 20 May 2016 10:26:36 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 20 May 2016 01:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,338,1459839600"; d="scan'208";a="971000461" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 20 May 2016 01:26:35 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 20 May 2016 09:26:34 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.38]) by irsmsx112.ger.corp.intel.com ([169.254.1.189]) with mapi id 14.03.0248.002; Fri, 20 May 2016 09:26:34 +0100 From: "Pattan, Reshma" To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues Thread-Index: AQHRr1YcbhooDAHe40O3UEUsiK4NyZ+7U93g///5TACAADIuoP//+56AgAXXowCAADDUoA== Date: Fri, 20 May 2016 08:26:33 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F0103538D@IRSMSX109.ger.corp.intel.com> References: <20160516113349.7d2a992f@miho> <3AEA2BF9852C6F48A459DA490692831F0102622D@IRSMSX109.ger.corp.intel.com> <5739A1D4.6010003@netinsight.net> <3AEA2BF9852C6F48A459DA490692831F010262FA@IRSMSX109.ger.corp.intel.com> <5739C83F.6010107@netinsight.net> <573EAEE0.4020802@netinsight.net> In-Reply-To: <573EAEE0.4020802@netinsight.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjliMWM2MDAtMDg4Yy00Yjk4LTkxYmYtNGM4Y2NlZjQ3ZDU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhuWEY0aXhHd0xDYWtrRzloM3U0NDE3M1JWdE5ZWCs2eHdYQ3B2MmhuM2c9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 08:26:37 -0000 > -----Original Message----- > From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net] > Sent: Friday, May 20, 2016 7:30 AM > To: Pattan, Reshma ; dev@dpdk.org; > thomas.monjalon@6wind.com > Subject: Re: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configur= e > with zero RX/TX queues >=20 > Ping? Any more comments on this? >=20 Hi, I don't have any objections, just let's wait if any other comments from= committee.=20 Thanks, Reshma > // Simon >=20 > On 2016-05-16 15:16, Simon K=E5gstr=F6m wrote: > > On 2016-05-16 14:43, Pattan, Reshma wrote: > >>>> This was added to allow devices, at least with one direction > >>>> (RX/TX) > >>> supported. As, devices with both directions disabled doesn't make se= nse > right? > >>> > >>> Well, not for running them, no. But this is a part of the shutdown > >>> procedure between tests (I should have been more clear I guess). > >> > >> Yes I understood this. But I am not sure if you can use > rte_eth_dev_configure(port, 0, 0) to free the resources. > >> Can you check if you can use rte_eth_dev_rx_queue_stop/ > >> rte_eth_dev_tx_queue_stop to achieve the same, because they do take ca= re > of releasing mbufs, but doesn't free the queue's sw-ring and queue. > > > > But isn't that very strange behavior. Aren't the descriptor rings > > allocated in rx_queue_setup()? If so, the sequence > > > > rx_queue_stop(); // Release buffers > > rx_queue_start(); > > > > would leave the descriptor ring empty after start, i.e., not able to > > receive data. > > > > // Simon > >