From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BAED729D1 for ; Sat, 11 Jun 2016 00:14:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 10 Jun 2016 15:14:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,452,1459839600"; d="scan'208";a="985122591" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 10 Jun 2016 15:14:41 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by IRSMSX102.ger.corp.intel.com ([169.254.2.10]) with mapi id 14.03.0248.002; Fri, 10 Jun 2016 23:14:40 +0100 From: "Pattan, Reshma" To: Aaron Conole CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support Thread-Index: AQHRw0inGk3POCUSakeSZt8bKdUQ2J/jNnYQ Date: Fri, 10 Jun 2016 22:14:39 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F0104CD7F@IRSMSX109.ger.corp.intel.com> References: <1465487895-5870-1-git-send-email-reshma.pattan@intel.com> <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <1465575534-23605-6-git-send-email-reshma.pattan@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjVjMWVkOWItODJhOS00Nzg1LTllZTAtMmY3MjEyMzhkYzQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktzSjZGOHk5RlA2T08xdnd4NHZibEJabDM2NzNkY212ZjZ0OURtOHlMWEU9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2016 22:14:43 -0000 Hi, > -----Original Message----- > From: Aaron Conole [mailto:aconole@redhat.com] > Sent: Friday, June 10, 2016 7:48 PM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 5/8] lib/librte_pdump: add new library = for > packet capturing support >=20 > Hi Reshma, >=20 > Reshma Pattan writes: >=20 > > Added new library for packet capturing support. > > > > Added public api rte_pdump_init, applications should call this as part > > of their application setup to have packet capturing framework ready. > > > > Added public api rte_pdump_uninit to uninitialize the packet capturing > > framework. > > > > Added public apis rte_pdump_enable and rte_pdump_disable to enable and > > disable packet capturing on specific port and queue. > > > > Added public apis rte_pdump_enable_by_deviceid and > > rte_pdump_disable_by_deviceid to enable and disable packet capturing > > on a specific device (pci address or name) and queue. > > > > Added public api rte_pdump_set_socket_dir to set the server socket > > path. >=20 > Thanks for this, it is quite useful! I am wondering, should the same API= work for > a client socket as well? The code becomes a bit easier to maintain, and = the API > behaves whether executed from client or server. > Thoughts? In this patch, server socket path is added as argument to rte_pdump_init() = , so server socket path must be passed while calling rte_pdump_init() API. And rte_pdump_set_socket_dir() is added for clients , as client need to kn= ow server socket path for contacting server, so application should pass se= rver socket path for clients using this API.=20 Could you please clarify which of the below option you are looking to have? a)If you want to have client and server sockets under same non default pat= h this can be done using same API. This just needs a tiny change in the cod= e. b)But if you want to have aserver and client sockets under different paths= , this can done using either of the below approaches. b1)use same rte_pdump_set_socket_dir() API, but add a new argument to sp= ecify if the path is for server or client socket.=20 (or)=20 b2)have two separate APIs to set client and server socket paths.=20 Which one do you prefer?=20 Konstantin, any comments from your side, please add.=20 Thanks, Reshma >=20 > Thanks, > Aaron >=20