From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 304BC6CAE for ; Wed, 15 Jun 2016 00:00:05 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 14 Jun 2016 15:00:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,472,1459839600"; d="scan'208";a="1001996562" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 14 Jun 2016 15:00:01 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by IRSMSX107.ger.corp.intel.com ([169.254.10.96]) with mapi id 14.03.0248.002; Tue, 14 Jun 2016 23:00:00 +0100 From: "Pattan, Reshma" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support Thread-Index: AQHRxiCHArvMp672bEiSAQ3jB2Dtwp/pWZqAgAAp2dA= Date: Tue, 14 Jun 2016 21:59:59 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F0104DFBC@IRSMSX109.ger.corp.intel.com> References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-1-git-send-email-reshma.pattan@intel.com> <1465897108-26548-6-git-send-email-reshma.pattan@intel.com> <3000552.2jYBPTLpa9@xps13> In-Reply-To: <3000552.2jYBPTLpa9@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGIxOWUxNTMtODdiYS00YzNhLWI4YmYtY2NjMGQzZGJiN2ZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikg0UjV1K0JVZ1QwWFliNlBwSEdvV1ZMQkx1MHVidWFcL1BRdzBRbTlcL1B5bz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 22:00:05 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, June 14, 2016 9:28 PM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet > capturing support >=20 > 2016-06-14 10:38, Reshma Pattan: > > The new librte_pdump library is added for packet capturing support. > > > > Added public api rte_pdump_init, applications should call this as part > > of their application setup to have packet capturing framework ready. > > > > Added public api rte_pdump_uninit to uninitialize the packet capturing > > framework. > > > > Added public apis rte_pdump_enable and rte_pdump_disable to enable and > > disable packet capturing on specific port and queue. > > > > Added public apis rte_pdump_enable_by_deviceid and > > rte_pdump_disable_by_deviceid to enable and disable packet capturing > > on a specific device (pci address or name) and queue. > > > > Added public api rte_pdump_set_socket_dir to set the server and client > > socket paths. >=20 > Reshma, it is not the right info to put in a commit log. > The description of each function is in the doxygen comments. > We need to have the overview, what is the design architecture (rings, mem= pool, > etc) and why you do that? Yes, I will update the commit message. >=20 > > MAINTAINERS | 4 + > > config/common_base | 5 + > > lib/Makefile | 1 + > > lib/librte_pdump/Makefile | 55 ++ > > lib/librte_pdump/rte_pdump.c | 913 > +++++++++++++++++++++++++++++++++ > > lib/librte_pdump/rte_pdump.h | 216 ++++++++ > > lib/librte_pdump/rte_pdump_version.map | 13 + > > mk/rte.app.mk | 1 + >=20 > And more importantly, we need a doc in the prog guide. >=20 Yes the document is added, I will move the document change to this patch. Thanks, Reshma