From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5BD4A5679 for ; Wed, 28 Sep 2016 13:00:08 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 28 Sep 2016 04:00:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,409,1470726000"; d="scan'208";a="14057896" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2016 04:00:05 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.6]) by IRSMSX106.ger.corp.intel.com ([169.254.8.209]) with mapi id 14.03.0248.002; Wed, 28 Sep 2016 12:00:03 +0100 From: "Pattan, Reshma" To: "Kerlin, MarcinX" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "thomas.monjalon@6wind.com" , "Kerlin, MarcinX" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] librte_ether: add protection against overwrite device data Thread-Index: AQHSGLFeMtQL81mItkSL8tsNcWCPBKCOuc2w Date: Wed, 28 Sep 2016 11:00:03 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F010A909A@IRSMSX109.ger.corp.intel.com> References: <1474901586-8706-2-git-send-email-marcinx.kerlin@intel.com> <1474974783-4861-1-git-send-email-marcinx.kerlin@intel.com> <1474974783-4861-2-git-send-email-marcinx.kerlin@intel.com> In-Reply-To: <1474974783-4861-2-git-send-email-marcinx.kerlin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjEzM2FhYTEtOWE5OS00MDE1LTk1N2YtMjk3ODMyYWZiYzc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjB5RU1PR1l3RCtXQ2lKejZmWk9QVE1WdWJKMyt0NDdRXC9hTjlVOVQwXC8yVT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] librte_ether: add protection against overwrite device data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 11:00:08 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcin Kerlin > Sent: Tuesday, September 27, 2016 12:13 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > thomas.monjalon@6wind.com; Kerlin, MarcinX > /** > * @internal > + * Returns a shared device data slot specified by the unique identifier = name. > + * > + * @param name > + * The pointer to the Unique identifier name for each shared Ethernet > +device > + * between multiple processes. > + * @return > + * - The pointer to the shared ethdev slot, on success. NULL on error > + */ > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char *name); > + 1) You forgot to remove this function declaration. 2)Check patch reported lines over 80 characters. Please run check patch on = next versions of patch before sending. WARNING:LONG_LINE_STRING: line over 80 characters #106: FILE: lib/librte_ether/rte_ethdev.c:258: + RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet por= ts by all " WARNING:LONG_LINE_STRING: line over 80 characters #118: FILE: lib/librte_ether/rte_ethdev.c:270: + RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already a= llocated by " WARNING:LONG_LINE: line over 80 characters #151: FILE: lib/librte_ether/rte_ethdev.c:503: + if (!strncmp(name, rte_eth_devices[i].data->name, strlen(na= me))) { 3)Can you also make sure to rebase when you send next patch version, as I = see some issue while applying the patch=20 Applying: librte_ether: add protection against overwrite device data error: lib/librte_ether/rte_ether_version.map: does not match index Patch failed at 0001 librte_ether: add protection against overwrite device = data Thanks, Reshma