DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Liu, Yong" <yong.liu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] mk: gcc -march support for intel processors code names
Date: Mon, 10 Oct 2016 15:21:57 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F010ADCFC@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <2578548.bj2dOLfXoi@xps13>

Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 10, 2016 3:26 PM
> To: Liu, Yong <yong.liu@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] mk: gcc -march support for intel processors
> code names
> 
> 2016-09-28 10:54, Liu, Yong:
> > Tested-by: Yong Liu <yong.liu@intel.com>
> >             FangFang Wei <fangfangx.wei@intel.com>
> [...]
> >    Description: Build test on different distributions
> >    Command / instruction:
> >      Verify build pass on listed distributions.
> >
> >      OS                   GCC            Kernel
> >      Ubuntu 16.04         5.4.0          4.4.0-36-generic
> >      Fedora23             5.3.1          4.2.3-300
> >      Fedora24             6.1.1          4.6.4-301
> >      Ubuntu 12.04         4.6.3          3.8.0-29
> >      Ubuntu 12.04 i686    4.6.3          3.8.0-29
> >      Ubuntu 14.04         4.8.4          3.16.0-30
> >      Ubuntu 14.04 i686    4.8.4          3.16.0-30
> >      Fedora18             4.7.2          3.6.10-4
> >      Fedora18 i686        4.7.2          3.6.10-4
> >      Fedora20             4.8.2          3.15.6-200
> >      Fedora20 i686        4.8.3          3.11.0
> >      Suse11SP2            4.5.1          3.0.13-0.2
> >      Suse12SP3            4.7.2          3.7.10-1.1
> >      RHEL7.0              4.8.2          3.10.0-123
> >      RHEL7.2              4.8.5          3.10.0-327
> >      CentOS7.0            4.8.5          3.10.0-327
> >      FreeBSD10.0          4.8.4          10.0-RELEASE
> >      FreeBSD10.3          4.8.5          10.3-RELEASE
> 
> I do not understand this test.
> This patch is dropping a lot of optimizations with compilers older than 4.9 !
> 
> Why not recommend GCC 4.9 and keep the graceful degradation for older
> versions, at least for one more year, even if it is not optimal for newer
> architectures?

I am ok with the idea, so should I send latest patch by keeping the code in  mk/toolchain/gcc/rte.toolchain-compat.mk untouched/intact?

Thanks,
Reshma

  reply	other threads:[~2016-10-10 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  2:54 Liu, Yong
2016-10-10 14:25 ` Thomas Monjalon
2016-10-10 15:21   ` Pattan, Reshma [this message]
2016-10-10 17:09     ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2016-08-15 15:02 [dpdk-dev] [PATCH] " Reshma Pattan
2016-08-22 14:19 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2016-09-02 14:17   ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AEA2BF9852C6F48A459DA490692831F010ADCFC@IRSMSX109.ger.corp.intel.com \
    --to=reshma.pattan@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).