DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH v2] mk: gcc -march support for intel processors code names
@ 2016-09-28  2:54 Liu, Yong
  2016-10-10 14:25 ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Liu, Yong @ 2016-09-28  2:54 UTC (permalink / raw)
  To: reshma.pattan; +Cc: dev

Tested-by: Yong Liu <yong.liu@intel.com>
            FangFang Wei <fangfangx.wei@intel.com>

- Tested Branch: dpdk/master
- Tested Commit: e22856313fff2db12d8e132dad446bbf74cf29a5
- CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
        Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 cases, 1 passed, 0 failed

- Prerequisites command / instruction:
   N/A

- Case:
   Description: Build test on different distributions
   Command / instruction:
     Verify build pass on listed distributions.

     OS                   GCC            Kernel
     Ubuntu 16.04         5.4.0          4.4.0-36-generic
     Fedora23             5.3.1          4.2.3-300
     Fedora24             6.1.1          4.6.4-301
     Ubuntu 12.04         4.6.3          3.8.0-29
     Ubuntu 12.04 i686    4.6.3          3.8.0-29
     Ubuntu 14.04         4.8.4          3.16.0-30
     Ubuntu 14.04 i686    4.8.4          3.16.0-30
     Fedora18             4.7.2          3.6.10-4
     Fedora18 i686        4.7.2          3.6.10-4
     Fedora20             4.8.2          3.15.6-200
     Fedora20 i686        4.8.3          3.11.0
     Suse11SP2            4.5.1          3.0.13-0.2
     Suse12SP3            4.7.2          3.7.10-1.1
     RHEL7.0              4.8.2          3.10.0-123
     RHEL7.2              4.8.5          3.10.0-327
     CentOS7.0            4.8.5          3.10.0-327
     FreeBSD10.0          4.8.4          10.0-RELEASE
     FreeBSD10.3          4.8.5          10.3-RELEASE

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] mk: gcc -march support for intel processors code names
@ 2016-08-15 15:02 Reshma Pattan
  2016-08-22 14:19 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
  0 siblings, 1 reply; 6+ messages in thread
From: Reshma Pattan @ 2016-08-15 15:02 UTC (permalink / raw)
  To: dev; +Cc: Reshma Pattan

The GCC 4.9 -march option supports the intel code names for processors,
for example -march=silvermont, -march=broadwell.
The RTE_MACHINE config flag can be used to pass code name to
the compiler as -march flag. Also old gcc versions compatibility code
for the intel platform is removed from
mk/toolchain/gcc/rte.toolchain-compat.mk

Release notes is updated.

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 doc/guides/rel_notes/release_16_11.rst   |  5 ++++
 mk/target/generic/rte.vars.mk            |  4 +++
 mk/toolchain/gcc/rte.toolchain-compat.mk | 47 ++------------------------------
 3 files changed, 11 insertions(+), 45 deletions(-)

diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 0b9022d..9f58133 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -36,6 +36,11 @@ New Features
 
      This section is a comment. Make sure to start the actual text at the margin.
 
+* **Added support for new gcc -march option.**
+
+  The GCC 4.9 ``-march`` option supports the Intel processor code names.
+  The config option ``RTE_MACHINE`` can be used to pass code names to the compiler as ``-march`` flag.
+
 
 Resolved Issues
 ---------------
diff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk
index 75a616a..b31e426 100644
--- a/mk/target/generic/rte.vars.mk
+++ b/mk/target/generic/rte.vars.mk
@@ -50,7 +50,11 @@
 #   - can define CPU_ASFLAGS variable (overriden by cmdline value) that
 #     overrides the one defined in arch.
 #
+ifneq ($(wildcard $(RTE_SDK)/mk/machine/$(RTE_MACHINE)/rte.vars.mk),)
 include $(RTE_SDK)/mk/machine/$(RTE_MACHINE)/rte.vars.mk
+else
+MACHINE_CFLAGS := -march=$(RTE_MACHINE)
+endif
 
 #
 # arch:
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 6eed20c..7f23721 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -42,51 +42,8 @@ GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
 GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
 GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
 
-# if GCC is older than 4.x
-ifeq ($(shell test $(GCC_VERSION) -lt 40 && echo 1), 1)
-	MACHINE_CFLAGS =
-$(warning You are using GCC < 4.x. This is neither supported, nor tested.)
-
-
-else
-# GCC graceful degradation
-# GCC 4.2.x - added support for generic target
-# GCC 4.3.x - added support for core2, ssse3, sse4.1, sse4.2
-# GCC 4.4.x - added support for avx, aes, pclmul
-# GCC 4.5.x - added support for atom
-# GCC 4.6.x - added support for corei7, corei7-avx
-# GCC 4.7.x - added support for fsgsbase, rdrnd, f16c, core-avx-i, core-avx2
 # GCC 4.9.x - added support for armv8-a+crc
 #
-	ifeq ($(shell test $(GCC_VERSION) -le 49 && echo 1), 1)
-		MACHINE_CFLAGS := $(patsubst -march=armv8-a+crc,-march=armv8-a+crc -D__ARM_FEATURE_CRC32=1,$(MACHINE_CFLAGS))
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -le 47 && echo 1), 1)
-		MACHINE_CFLAGS := $(patsubst -march=core-avx-i,-march=corei7-avx,$(MACHINE_CFLAGS))
-		MACHINE_CFLAGS := $(patsubst -march=core-avx2,-march=core-avx2,$(MACHINE_CFLAGS))
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -lt 46 && echo 1), 1)
-		MACHINE_CFLAGS := $(patsubst -march=corei7-avx,-march=core2 -maes -mpclmul -mavx,$(MACHINE_CFLAGS))
-		MACHINE_CFLAGS := $(patsubst -march=corei7,-march=core2 -maes -mpclmul,$(MACHINE_CFLAGS))
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -lt 45 && echo 1), 1)
-		MACHINE_CFLAGS := $(patsubst -march=atom,-march=core2 -mssse3,$(MACHINE_CFLAGS))
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -lt 44 && echo 1), 1)
-		MACHINE_CFLAGS := $(filter-out -mavx -mpclmul -maes,$(MACHINE_CFLAGS))
-		ifneq ($(findstring SSE4_2, $(CPUFLAGS)),)
-			MACHINE_CFLAGS += -msse4.2
-		endif
-		ifneq ($(findstring SSE4_1, $(CPUFLAGS)),)
-			MACHINE_CFLAGS += -msse4.1
-		endif
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -lt 43 && echo 1), 1)
-		MACHINE_CFLAGS := $(filter-out -msse% -mssse%,$(MACHINE_CFLAGS))
-		MACHINE_CFLAGS := $(patsubst -march=core2,-march=generic,$(MACHINE_CFLAGS))
-		MACHINE_CFLAGS += -msse3
-	endif
-	ifeq ($(shell test $(GCC_VERSION) -lt 42 && echo 1), 1)
-		MACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS))
-	endif
+ifeq ($(shell test $(GCC_VERSION) -le 49 && echo 1), 1)
+MACHINE_CFLAGS := $(patsubst -march=armv8-a+crc,-march=armv8-a+crc -D__ARM_FEATURE_CRC32=1,$(MACHINE_CFLAGS))
 endif
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-10-10 17:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28  2:54 [dpdk-dev] [PATCH v2] mk: gcc -march support for intel processors code names Liu, Yong
2016-10-10 14:25 ` Thomas Monjalon
2016-10-10 15:21   ` Pattan, Reshma
2016-10-10 17:09     ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2016-08-15 15:02 [dpdk-dev] [PATCH] " Reshma Pattan
2016-08-22 14:19 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2016-09-02 14:17   ` Pattan, Reshma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).