From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD
Date: Tue, 6 Mar 2018 12:12:03 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2A642D@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com>
>
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n)
> +$(error "Please enable CONFIG_RTE_LIBRTE_PMD_PCAP") endif
> +
How about combining If(($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) check with below existing if check?
with this, dpdk-pdump will be compiled only when both the flags are enabled.
> ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y)
>
> APP = dpdk-pdump
> --
> 1.9.1
next prev parent reply other threads:[~2018-03-06 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 7:57 Vipin Varghese
2018-03-05 14:32 ` Ferruh Yigit
2018-03-06 8:45 ` Varghese, Vipin
2018-03-06 11:57 ` Ferruh Yigit
2018-03-06 12:12 ` Pattan, Reshma [this message]
2018-03-12 17:46 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A2A642D@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).