From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D044D255 for ; Thu, 29 Mar 2018 16:32:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 07:32:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="42350257" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2018 07:32:23 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by IRSMSX107.ger.corp.intel.com ([169.254.10.157]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 15:32:22 +0100 From: "Pattan, Reshma" To: "Zhang, Qi Z" , "adrien.mazarguil@6wind.com" CC: "dev@dpdk.org" , "Doherty, Declan" , "Chandran, Sugesh" , "Glynn, Michael J" , "Liu, Yu Y" , "Ananyev, Konstantin" , "Richardson, Bruce" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH 3/4] ether: add more protocol support in flow API Thread-Index: AQHTxyjMegzBv9IEmU+YcIKxUgxgIaPnHqTA Date: Thu, 29 Mar 2018 14:32:22 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2BBCA8@irsmsx110.ger.corp.intel.com> References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com> <1522279780-34842-4-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1522279780-34842-4-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/4] ether: add more protocol support in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 14:32:27 -0000 Hi, > + > + /** > + * Matches ARP IPv4 header. > + * > + * See struct rte_flow_item_arp. > + */ > + TE_FLOW_ITEM_TYPE_ARP, > + R is missing in name RTE_, similary in other places. + /** + * Match ICMPv6 Source Link-Layer Address. + * + * See struct rte_flow_item_icmpv6_tll. + */ + RTE_FLOW_ITEM_TYPE_ICMPV6_TLL, Description in comments not correct w.r.t enum name. No need of ',' at the end. > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_ARP. */ #ifndef __cplusplus > +static const struct rte_flow_item_arp rte_flow_item_arp_mask =3D { > + .hdr =3D { > + .arp_data =3D { > + .arp_sha =3D { > + .addr_bytes =3D "\xff\xff\xff\xff\xff\xff", > + }, > + .arp_sip =3D RTE_BE32(0xffffffff), > + .arp_tha =3D { > + .addr_bytes =3D "\xff\xff\xff\xff\xff\xff", > + }, > + .arp_tip =3D RTE_BE32(0xffffffff), > + }, > + }, > +}; > +#endif > + Indentation issue in above code. > +/** > + * RTE_FLOW_ITEM_TYPE_IPV6_EXT_HDR_ANY > + * > + * Matches any IPv6 extension header. > + */ > +struct rte_flow_item_ipv6_ext_hdr_any { > + uint8_t next_hdr; > +}; > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_IPV6_EXT_HDR_ANY. */ > #ifndef > +__cplusplus static const struct rte_flow_item_ipv6_ext_hdr_any > +rte_flow_item_ipv6_ext_any_mask =3D { > + .next_hdr =3D 0xff, > +}; > +#endif General comment, Is that ok to move all structure declarations together and= =20 all default mask settings inside one ifndef _cpluscplus? > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_ICMPV6_TGT_ADDR */ #ifndef > +__cplusplus static const struct rte_flow_item_icmpv6_tgt_addr > +rte_flow_item_icmpv6_tgt_addr_mask =3D { > + .addr =3D "\xff\xff\xff\xff", You should assign all 16bytes wilth xff? You are assigning only first 4. Thanks, Reshma