From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8267D2C5E for ; Wed, 25 Apr 2018 00:35:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 15:35:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,324,1520924400"; d="scan'208";a="45776660" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2018 15:35:45 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by IRSMSX153.ger.corp.intel.com ([169.254.9.3]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 23:35:44 +0100 From: "Pattan, Reshma" To: Thomas Monjalon CC: "dev@dpdk.org" , "Hunt, David" , "Richardson, Bruce" , "Parthasarathy, JananeeX M" Thread-Topic: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests Thread-Index: AQHT0Z98jkrk1WfVkkOj9htwKVuCGaQO2VGAgADpKoCAABaW0P///TqAgAAcEmCAAJJbgIAAEP/A Date: Tue, 24 Apr 2018 22:35:42 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2C9508@irsmsx110.ger.corp.intel.com> References: <1523022706-12231-1-git-send-email-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2C9138@irsmsx110.ger.corp.intel.com> <2027071.Zq3VvV6ELG@xps> In-Reply-To: <2027071.Zq3VvV6ELG@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 22:35:48 -0000 Hi Thomas, I sent it few mins back. Can you check and apply Thanks, Reshma > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 24, 2018 11:34 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Hunt, David ; Richardson, Bruce > ; Parthasarathy, JananeeX M > > Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit > tests >=20 > 24/04/2018 14:51, Pattan, Reshma: > > From: Hunt, David > > > On 24/4/2018 12:23 PM, Pattan, Reshma wrote: > > > > From: Richardson, Bruce > > > >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote: > > > >>> 11/04/2018 16:14, Reshma Pattan: > > > >>>> Unit Testcases are added for power_acpi_cpu_freq, > > > power_kvm_vm_test > > > >>>> to improve coverage > > > >>>> > > > >>>> Signed-off-by: Jananee Parthasarathy > > > >>>> > > > >>>> Acked-by: David Hunt > > > >>> Applied, thanks > > > >>> > > > >> Sadly, this patch seems to break shared library builds. If you > > > >> try doing "make test-build" with shared libraries on it will > > > >> fail, or if you do a meson build using shared libraries you will g= et the > same result. > > > >> > > > >> The root cause is that the function guest_channel_host_connect() > > > >> is a private function and so is not listed in the shared library > > > >> map file, preventing the test app from linking. > > > >> > > > > Any action from my side required? Let me know. > > > > > > Reshma, > > > Looking at this, I think this particular unit test needs to be > > > removed. The way it is at the moment, it's "faking" the connect, > > > then any commands that are sent to the dummy host are only really to > > > test to see if the API breaks, which is going to be captured by > > > compilation tests anyway. I don't see the value of this unit test > > > unless you have the full host setup underneath is, in which case it's= no > longer a unit test. > > > Also, we don't want to make these functions public, as they are only > > > of use to the library internally, and there is no use for them > > > publicly (unless a guest wants to fake a connection to a non-existent= host). > > > > > > What do you think? > > > > Fine, we are reverting the changes and will send the patch soon. >=20 > Where is the patch? > I will revert it myself. >=20