Re: [dpdk-dev] [PATCH] test: add unit tests for latencystats library

["Pattan, Reshma" <reshma.pattan@intel.com>]

Hi,

> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Friday, July 6, 2018 7:01 PM
> To: dev@dpdk.org
> Cc: Horton, Remy <remy.horton@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] test: add unit tests for latencystats library
> 
> From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> 
> Unit Test Cases added for latencystats library.

Need to mention dependency of sample oacket formward functions patch

> diff --git a/test/test/test_latencystats.c b/test/test/test_latencystats.c new file
> mode 100644 index 000000000..6d9809883
> --- /dev/null
> +++ b/test/test/test_latencystats.c
> +
> +/* Test case to get names of latency stats */ static int
> +test_latencystats_get_names(void)
> +{
> +	int ret = 0;
> +	int size = 0;
> +	struct rte_metric_name names[NUM_STATS] = {0};

NUM_STATS is not defined here nor in sample_packet_forwrd code patch.
Am I missing something here.
 
Include  this test to auto_test suite.

> +			printf("Failed: Names are not matched");
> +	}

Missing \n in printf.

Thanks,
Reshma