From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 525265F51 for ; Tue, 10 Jul 2018 13:55:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 04:55:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,334,1526367600"; d="scan'208";a="214823930" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga004.jf.intel.com with ESMTP; 10 Jul 2018 04:55:08 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.124]) by IRSMSX108.ger.corp.intel.com ([169.254.11.169]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 12:55:07 +0100 From: "Pattan, Reshma" To: "Parthasarathy, JananeeX M" , "dev@dpdk.org" CC: "Horton, Remy" , "Babu Radhakrishnan, AgalyaX" Thread-Topic: [PATCH] test: add unit tests for latencystats library Thread-Index: AQHUFVNa4Z4yID/BYUGkspb8AuLTYaSIWvCg Date: Tue, 10 Jul 2018 11:55:07 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A36D2DD@IRSMSX109.ger.corp.intel.com> References: <1530900059-9531-1-git-send-email-jananeex.m.parthasarathy@intel.com> In-Reply-To: <1530900059-9531-1-git-send-email-jananeex.m.parthasarathy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test: add unit tests for latencystats library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 11:55:14 -0000 Hi, > -----Original Message----- > From: Parthasarathy, JananeeX M > Sent: Friday, July 6, 2018 7:01 PM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH] test: add unit tests for latencystats library >=20 > From: Jananee Parthasarathy >=20 > Unit Test Cases added for latencystats library. Need to mention dependency of sample oacket formward functions patch > diff --git a/test/test/test_latencystats.c b/test/test/test_latencystats.= c new file > mode 100644 index 000000000..6d9809883 > --- /dev/null > +++ b/test/test/test_latencystats.c > + > +/* Test case to get names of latency stats */ static int > +test_latencystats_get_names(void) > +{ > + int ret =3D 0; > + int size =3D 0; > + struct rte_metric_name names[NUM_STATS] =3D {0}; NUM_STATS is not defined here nor in sample_packet_forwrd code patch. Am I missing something here. =20 Include this test to auto_test suite. > + printf("Failed: Names are not matched"); > + } Missing \n in printf. Thanks, Reshma