From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <reshma.pattan@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BDB0CF72 for <dev@dpdk.org>; Tue, 24 Jul 2018 14:39:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 05:39:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,398,1526367600"; d="scan'208";a="67114057" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jul 2018 05:39:28 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.124]) by IRSMSX103.ger.corp.intel.com ([169.254.3.208]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 13:39:27 +0100 From: "Pattan, Reshma" <reshma.pattan@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Singh, Jasvinder" <jasvinder.singh@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "motih@mellanox.com" <motih@mellanox.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInI35Qt0FFgen0+ndsg3ReJnD6SeLF2AgAATHYCAABIiQA== Date: Tue, 24 Jul 2018 12:39:27 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A37608A@IRSMSX109.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> In-Reply-To: <1925999.Zqez9Xlb98@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Jul 2018 12:39:31 -0000 Hi, Jasvinder is OOO, let me have a look and send the next version of patch. Thanks, Reshma > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 24, 2018 1:34 PM > To: Singh, Jasvinder <jasvinder.singh@intel.com> > Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>; > Pattan, Reshma <reshma.pattan@intel.com>; motih@mellanox.com; > olivier.matz@6wind.com; Dumitrescu, Cristian > <cristian.dumitrescu@intel.com> > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 > Important note: > testpmd is currently really broken. > We cannot have a RC2 until it is fixed. >=20 >=20 > 24/07/2018 13:25, Thomas Monjalon: > > 23/07/2018 12:44, Jasvinder Singh: > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > character (EOT) on the empty command line. > > > > Please describe what is the issue and what is the cause. > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > Reported-by: Mordechay Haimovsky <motih@mellanox.com> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > > > --- > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > It is very suspicious to change the cmdline library. > > If there is a bug in this library, it deserves a separate fix. >=20 >=20