From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8C8327CBC; Thu, 20 Sep 2018 12:25:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 03:25:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,398,1531810800"; d="scan'208";a="265184399" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga006.fm.intel.com with ESMTP; 20 Sep 2018 03:25:22 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.156]) by IRSMSX103.ger.corp.intel.com ([169.254.3.234]) with mapi id 14.03.0319.002; Thu, 20 Sep 2018 11:25:22 +0100 From: "Pattan, Reshma" To: "longtb5@viettel.com.vn" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] latency: clear mbuf timestamp after latency calculation Thread-Index: AQHUT/Iq5UORg+4QGE6Fx+8iyjIzP6T49kTg Date: Thu, 20 Sep 2018 10:25:21 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A39B0A6@IRSMSX109.ger.corp.intel.com> References: <1537345496-70207-1-git-send-email-longtb5@viettel.com.vn> <1537345834-70456-1-git-send-email-longtb5@viettel.com.vn> In-Reply-To: <1537345834-70456-1-git-send-email-longtb5@viettel.com.vn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] latency: clear mbuf timestamp after latency calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 10:25:25 -0000 Hi, > -----Original Message----- > From: longtb5@viettel.com.vn [mailto:longtb5@viettel.com.vn] > Sent: Wednesday, September 19, 2018 9:23 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; Bao-Long Tran ; > stable@dpdk.org > Subject: [PATCH] latency: clear mbuf timestamp after latency calculation >=20 > The timestamp of a mbuf should be cleared after that mbuf was used for > latency calculation, otherwise future packets which reuse the same mbuf > would inherit that previous timestamp. The latencystats library looks for > mbuf with non-zero timestamp, thus incorrectly inherited value would resu= lt > in incorrect latency measurement. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Bao-Long Tran You need to add the Fixes line just before CC: in the commit message.=20 Original commit that introduced the bug was 5cd3cac9ed. So fixes should b= e added like below Fixes: 5cd3cac9ed ("latency: added new library for latency stats"). =20 You can send v2 with fixes line and my ack. Other than that=20 Acked-by: Reshma Pattan