DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "longtb5@viettel.com.vn" <longtb5@viettel.com.vn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Incorrect latencystats implementation
Date: Thu, 20 Sep 2018 13:08:45 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A39B32D@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1537345496-70207-1-git-send-email-longtb5@viettel.com.vn>



> -----Original Message-----
> From: longtb5@viettel.com.vn [mailto:longtb5@viettel.com.vn]
> Sent: Wednesday, September 19, 2018 9:17 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; Bao-Long Tran <longtb5@viettel.com.vn>
> Subject: Incorrect latencystats implementation
> 
> 
> I have submit a patch to implement the trivial fix. For the drop case I can
> think of 2 options. We can either clear timestamp when putting mbufs back
> to their pool, or change lib latencystats implementation to perform packet
> selection at TX callback and let RX callback add timestamp to every packet.
> Both option could affect performance but I think the second option is less
> aggressive.

What happens when applications drop the packets? Do they free the mbuf?
In such case, can application set the timestamp to 0 before freeing the mbuf, instead of making
these changes in latency library.? 

Regards,
Reshma

  parent reply	other threads:[~2018-09-20 13:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  8:17 longtb5
2018-09-19  8:22 ` [dpdk-dev] [PATCH] latency: clear mbuf timestamp after latency calculation longtb5
2018-09-20 10:25   ` Pattan, Reshma
2018-09-20 12:16     ` longtb5
2018-09-20 11:16   ` [dpdk-dev] [PATCH v2] " longtb5
2018-09-20 13:08 ` Pattan, Reshma [this message]
2018-09-21  1:58   ` [dpdk-dev] Incorrect latencystats implementation longtb5
2018-09-21 11:15     ` Pattan, Reshma
2018-09-21 12:14       ` Ananyev, Konstantin
2018-09-21 14:58         ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A39B32D@IRSMSX109.ger.corp.intel.com \
    --to=reshma.pattan@intel.com \
    --cc=dev@dpdk.org \
    --cc=longtb5@viettel.com.vn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).