DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Marohn, Byron" <byron.marohn@intel.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: reduce test duration for efd autotest
Date: Wed, 17 Oct 2018 13:33:24 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3B990E@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1537971540-31443-1-git-send-email-jananeex.m.parthasarathy@intel.com>



> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Wednesday, September 26, 2018 3:19 PM
> To: dev@dpdk.org
> 
>  	struct rte_efd_table *handle = NULL;
>  	uint32_t num_rules_in = TABLE_SIZE;
> -	uint8_t simple_key[EFD_TEST_KEY_LEN];

You need to remove EFD_TEST_KEY_LEN macro from the code now, as it is not is not used now.

Also seems like they want to use the key of length 8 bytes as per this test.
But after your changes we are going to have one byte key , so is the test behaving same before and after this key change?
 

> +		val = mrand48() & VALUE_BITMASK;

Can we use rte_rand() here instead of mrand48()? 
What was the reason for using mrand8()?

Thanks,
Reshma

  reply	other threads:[~2018-10-17 13:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 14:19 Jananee Parthasarathy
2018-10-17 13:33 ` Pattan, Reshma [this message]
2018-10-17 14:34 ` Pattan, Reshma
2018-10-31 14:30 ` [dpdk-dev] [PATCH v2] " Jananee Parthasarathy
2018-10-31 16:11   ` Pattan, Reshma
2018-11-29  7:36   ` [dpdk-dev] [PATCH v3] " Jananee Parthasarathy
2019-01-20 21:25     ` Thomas Monjalon
2019-07-04 21:46       ` Thomas Monjalon
2019-07-19  9:01         ` Parthasarathy, JananeeX M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A3B990E@irsmsx110.ger.corp.intel.com \
    --to=reshma.pattan@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).