From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C15AB1D7; Tue, 13 Nov 2018 17:58:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 08:58:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,228,1539673200"; d="scan'208";a="104041516" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2018 08:58:13 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.20]) by IRSMSX154.ger.corp.intel.com ([169.254.12.166]) with mapi id 14.03.0415.000; Tue, 13 Nov 2018 16:58:12 +0000 From: "Pattan, Reshma" To: "Chaitanya Babu, TalluriX" , "dev@dpdk.org" CC: "Marohn, Byron" , "De Lara Guarch, Pablo" , "stable@dpdk.org" Thread-Topic: [PATCH] lib: fix write unlock during ring creation Thread-Index: AQHUe1BAbQMG8CDInk2hOzYCPCoGzqVN7KSQ Date: Tue, 13 Nov 2018 16:58:11 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D301C@irsmsx110.ger.corp.intel.com> References: <1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com> In-Reply-To: <1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWEyZTE2YmEtMGMxMC00YTRkLThiOTAtMDFmYTcxZGZiZDQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOG1wZ3Fzc3VvN3pBUUNzVWxrcXk4RllPUVhIN1pla0tyaTV1NEF2VUN2Y1RsbDVsRlZZY2MrRDlYa0pQUGEzMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib: fix write unlock during ring creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 16:58:15 -0000 > -----Original Message----- > From: Chaitanya Babu, TalluriX > Sent: Tuesday, November 13, 2018 12:55 PM > To: dev@dpdk.org > Cc: Marohn, Byron ; Pattan, Reshma > ; De Lara Guarch, Pablo > ; Chaitanya Babu, TalluriX > ; stable@dpdk.org > Subject: [PATCH] lib: fix write unlock during ring creation Heading should have lib/efd: >=20 > In rte_efd_create() write lock has already been unlocked before ring crea= tion > itself. > So second unlock after the ring creation has been removed and added freei= ng of > tail queue entry and efd table. Changes do not have free of tailq entry, so remove the mention of it from = commit message. > - /* Create ring (Dummy slot index is not enqueued) */ > + /* Create ring (Dummy slot index is not enqueued) */ Undo this change. Unrelated. Other than these looks ok. Acked-by: Reshma Pattan Thanks, Reshma