From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 893BB1B553 for ; Thu, 13 Dec 2018 15:42:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 06:42:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,349,1539673200"; d="scan'208";a="283307925" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga005.jf.intel.com with ESMTP; 13 Dec 2018 06:42:39 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.233]) by IRSMSX103.ger.corp.intel.com ([169.254.3.157]) with mapi id 14.03.0415.000; Thu, 13 Dec 2018 14:42:39 +0000 From: "Pattan, Reshma" To: "Varghese, Vipin" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "dev@dpdk.org" , "Mcnamara, John" CC: "thomas@monjalon.net" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool Thread-Index: AQHUkqICZCwlZkA/tEiQLLOybHnaR6V8t13A Date: Thu, 13 Dec 2018 14:42:38 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3EA1F0@irsmsx110.ger.corp.intel.com> References: <20181203055000.39012-2-vipin.varghese@intel.com> <20181213050842.64587-1-vipin.varghese@intel.com> In-Reply-To: <20181213050842.64587-1-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTM2YTdhNWEtYjkzNi00ODliLTkzZTktOTYwZDQwMzhhZjFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibmNGaWxmQkNlXC9lN0taZU9wVnh4MWpqclwvVzZDSzVqQjV1eHZSenFpelNzc0hWaFBBMWVIK0l5aUdoYmNVT0dGIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 14:42:43 -0000 Hi > -----Original Message----- > From: Varghese, Vipin > Sent: Thursday, December 13, 2018 5:09 AM > To: Ananyev, Konstantin ; > stephen@networkplumber.org; Pattan, Reshma ; > dev@dpdk.org; Mcnamara, John > Cc: thomas@monjalon.net; Byrne, Stephen1 ; > Patel, Amol ; Varghese, Vipin > > Subject: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool >=20 > This patch adds new debug functions to existing proc-info tool. >=20 > Motivation > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > DPDK proc-info tool is been widely used as secondary process to collect s= tats for > any primary process. But these are limited to DPDK NIC ports and basic me= mory > usage. >=20 > Motivation > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > This patch tries to address the short coming by adding debug for port, tr= affic > manager, crypto, ring and mempool. With these additional information in t= ool > will be able to deliver helpful data to debug issues and performance vari= ance. >=20 > Status > =3D=3D=3D=3D=3D=3D >=20 > With the following patch set debug data has been collected from customers > using DPDK instances. Analysing the information helped to suggest the nex= t > debug steps and solutions for fixing the issues. >=20 > Next Steps > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > - add event dev debug information. > - enhance iter_mempool for INLINE crypto entries. > - add debug for libraries like hash and acl. > - explore debug possibility for ring and list. > - add links and reference to 'how to guide' for 'debug and troubleshoot'= . >=20 > Patch set Information > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > Patch includes set of 9 patches: > * 0 : to introduce the debug function enhancement for proc-info > * 1 : MACRO and help usage for new functions > * 2 : string compare for new functions > * 3 : invocation for the new prototypes > * 4 : show port > * 5 : show tm > * 6 : show crypto > * 7 : ring element debug > * 8 : mempool element debug > * 9 : iterate mempoool elements >=20 Small nits 9th patch in this set is doc. So above info need to be corrected. =20 if you are addressing my earlier comment of separating out mempool element = iteration changes in to separate new patch 9/10 .Please keep my ack in next= version Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan