From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 18E381B519
 for <dev@dpdk.org>; Thu, 13 Dec 2018 18:15:16 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 13 Dec 2018 09:15:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,349,1539673200"; d="scan'208";a="127644630"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga004.fm.intel.com with ESMTP; 13 Dec 2018 09:15:15 -0800
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.233]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.208]) with mapi id 14.03.0415.000;
 Thu, 13 Dec 2018 17:15:14 +0000
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko"
 <marko.kovacevic@intel.com>
Thread-Topic: [PATCH] pdump: remove deprecated APIs
Thread-Index: AQHUirSDIuV9WFyrr0GzrVSuIoHxm6V893cA
Date: Thu, 13 Dec 2018 17:15:13 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3EA30F@irsmsx110.ger.corp.intel.com>
References: <20181122025541.2120-1-tiwei.bie@intel.com>
 <20181203025857.23670-1-tiwei.bie@intel.com>
In-Reply-To: <20181203025857.23670-1-tiwei.bie@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGFkN2M3NjctOTJkNy00N2RlLWFlMWMtNjg3ZWM0YmNjOTIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0s1elFoVUpqZ0NUd3RldCtORWplaWs0a2lSWFF6MDF6U09OeEc1YU1pUHJycWh5aGhwdXRpNlwvVGlHUTJ4ZXcifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] pdump: remove deprecated APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 17:15:17 -0000

Hi,

> -----Original Message-----
> From: Bie, Tiwei
> Sent: Monday, December 3, 2018 2:59 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
> Subject: [PATCH] pdump: remove deprecated APIs
>=20
> We already changed to use generic IPC in pdump since below commit:
>=20
> commit 660098d61f57 ("pdump: use generic multi-process channel")
>=20
> The `rte_pdump_set_socket_dir()`, the `path` parameter of `rte_pdump_init=
()`
> and the `enum rte_pdump_socktype` have been deprecated since then. This
> commit removes these deprecated APIs and also bumps the pdump ABI.
>=20
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> changes:
> - update release notes;
> - minor updates in pdump_lib.rst;
>=20
>  app/test-pmd/testpmd.c                 |  2 +-
>  doc/guides/prog_guide/pdump_lib.rst    | 18 ++++--------------
>  doc/guides/rel_notes/deprecation.rst   |  7 -------
>  doc/guides/rel_notes/release_19_02.rst |  6 +++++-
>  lib/librte_pdump/Makefile              |  2 +-
>  lib/librte_pdump/meson.build           |  2 +-
>  lib/librte_pdump/rte_pdump.c           |  9 +--------
>  lib/librte_pdump/rte_pdump.h           | 34 +---------------------------=
------
>  lib/librte_pdump/rte_pdump_version.map |  1 -
>  9 files changed, 14 insertions(+), 67 deletions(-)
>=20
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>