From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2D1246CD8; Tue, 15 Jan 2019 11:09:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 02:09:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="116868923" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga008.fm.intel.com with ESMTP; 15 Jan 2019 02:09:03 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 15 Jan 2019 10:09:02 +0000 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.16]) by irsmsx155.ger.corp.intel.com ([169.254.14.157]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 10:09:02 +0000 From: "Pattan, Reshma" To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup Thread-Index: AQHUqdZhE+dW0g+9KU2PLD3ZCz2QmqWvh2gAgACP7xA= Date: Tue, 15 Jan 2019 10:09:01 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> References: <20190111174134.39772-1-reshma.pattan@intel.com> <20190111175134.40273-1-reshma.pattan@intel.com> <3007842.nGy45PVQPd@xps> In-Reply-To: <3007842.nGy45PVQPd@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjJhYTRiY2QtM2VjZS00NWIzLTg5ZGUtYzEyOGU3MDg4NTVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibnBxcTVvVUYwcDRjbjZRNVwvbno4Qnl3cnZaazRENlZlZHBzQVArTWEwZm5WZUJSTzBtUjRJQm0rZjlyYXhPXC8rIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:09:05 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, January 15, 2019 12:59 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; stable@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup >=20 > 11/01/2019 18:51, Reshma Pattan: > > Virtual devices added in pdump application using rte_eal_hotplug_add > > should be removed explicitly while existing the pdump application, > > otherwise the >=20 > existing -> exiting ? >=20 > > subsequent run of the pdump application will fail with the reason that > > virtual devices with the same name already exists in primary. > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev > > attach") > > CC: stable@dpdk.org > > CC: ferruh.yigit@intel.com >=20 > Why is it marked as a fix of this commit? > Is it a miss in the conversion from ethdev attach calls? > Or a changed behaviour with hotplug functions? >=20 >=20 It is changed behaviour with hotplug functions. Thanks, Reshma