From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2C764532C; Tue, 15 Jan 2019 11:25:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 02:25:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="310537296" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga006.fm.intel.com with ESMTP; 15 Jan 2019 02:25:45 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.16]) by IRSMSX151.ger.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 10:25:44 +0000 From: "Pattan, Reshma" To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup Thread-Index: AQHUqdZhE+dW0g+9KU2PLD3ZCz2QmqWvh2gAgACP7xCAAAobgIAAAKrA Date: Tue, 15 Jan 2019 10:25:43 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A400A38@irsmsx110.ger.corp.intel.com> References: <20190111174134.39772-1-reshma.pattan@intel.com> <3007842.nGy45PVQPd@xps> <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> <1859916.dnCeAC13tB@xps> In-Reply-To: <1859916.dnCeAC13tB@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzAxMDBmNzktNTczZC00MjFmLTljMTMtOTRkMTlhNTM0NjVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHNobVIyUFlBYUk3bmVYSXNYOVR0WExyb1hFbTZSOU1hV3ZFVTdEbjllQTBaRW1FYk5xTVwveTdtalRBOThKXC9EIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:25:47 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, January 15, 2019 10:11 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; stable@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup >=20 > 15/01/2019 11:09, Pattan, Reshma: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 11/01/2019 18:51, Reshma Pattan: > > > > Virtual devices added in pdump application using > > > > rte_eal_hotplug_add should be removed explicitly while existing > > > > the pdump application, otherwise the > > > > > > existing -> exiting ? > > > > > > > subsequent run of the pdump application will fail with the reason > > > > that virtual devices with the same name already exists in primary. > > > > > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev > > > > attach") > > > > CC: stable@dpdk.org > > > > CC: ferruh.yigit@intel.com > > > > > > Why is it marked as a fix of this commit? > > > Is it a miss in the conversion from ethdev attach calls? > > > Or a changed behaviour with hotplug functions? > > > > It is changed behaviour with hotplug functions. >=20 > Please, could you explain? >=20 Attach calls were replaced with rte_eal_hotplug_remove() in pdump in the co= mmit id given in Fixes line. And after this change, the subsequent runs(other than 1st) of pdump applica= tion are failing with below error 1)Pdump application error: EAL: Failed to hotplug add device EAL: Error - exiting with code: 1 Cause: vdev creation failed:create_mp_ring_vdev:706 2)And error on primary application side is below: testpmd> Ethernet device with name net_pcap_rx_0 already allocated EAL: Failed to hotplug add device on primary So, the dev added in secondary should be removed during its exit by calling= rte_eal_hotplug_remove (). So, that is the reason I chose the Fixes: commit as the one where rte_eal_= hotplug_add() replaced the attach. Earlier with attach calls though not detaching the devices upon application= exit, these issues are not seen. Thanks, Reshma