From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C9AED4F90 for ; Tue, 2 Apr 2019 18:13:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 09:13:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,301,1549958400"; d="scan'208";a="139370512" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 02 Apr 2019 09:13:31 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by IRSMSX102.ger.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 17:13:30 +0100 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" , "Kovacevic, Marko" , "david.marchand@redhat.com" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [PATCH v5 2/2] app/pdump: enhance to support multi-core capture Thread-Index: AQHU6TUZolXNuEnbuUCpahSBBxRO8qYo+TFw Date: Tue, 2 Apr 2019 16:13:30 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4341B4@irsmsx110.ger.corp.intel.com> References: <20190402043318.20382-3-vipin.varghese@intel.com> <20190402091836.35779-1-vipin.varghese@intel.com> <20190402091836.35779-3-vipin.varghese@intel.com> In-Reply-To: <20190402091836.35779-3-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVlYTc5ZmYtMTZjNi00MDA2LWExMDMtM2EzMzY2Y2IyNTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGNsaGgyXC9OR3c2V1dDWElzRFpyWGVkUG5oZ2wwZ0RlTHVoMVp0cXI4RHF4SVFETW50NVZFXC9sc3ByUytnSlNCIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 16:13:34 -0000 > -----Original Message----- > From: Varghese, Vipin >=20 > @@ -152,7 +157,7 @@ pdump_usage(const char *prgname) > "[ring-size=3Ddefault:16384]," > "[mbuf-size=3Ddefault:2176]," > "[total-num-mbufs=3D mbufs>default:65535]'\n", > - prgname); > + prgname, CMD_LINE_OPT_MULTI, IMO, simple short options can be used instead of long, as this option don'= t have any arguments to pass. >=20 > +static int > +dump_packets_core(void *arg) > +{ > + struct pdump_tuples *pt =3D (struct pdump_tuples *) arg; > + > + printf(" core (%u); port %u device (%s) queue %u\n", > + rte_lcore_id(), pt->port, pt->device_id, pt->queue); Log message can be improved to be " packet_dump for port running on = core " > + fflush(stdout); Why is fflush used here and in below other places? >=20 > +The ``--multi`` command line option is optional argument. If passed, > +capture will be running on unqiue cores for all ``--pdump`` options. If Typo unique Thanks, Reshma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B624AA0679 for ; Tue, 2 Apr 2019 18:13:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 835124F94; Tue, 2 Apr 2019 18:13:34 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C9AED4F90 for ; Tue, 2 Apr 2019 18:13:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 09:13:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,301,1549958400"; d="scan'208";a="139370512" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 02 Apr 2019 09:13:31 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by IRSMSX102.ger.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 17:13:30 +0100 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" , "Kovacevic, Marko" , "david.marchand@redhat.com" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [PATCH v5 2/2] app/pdump: enhance to support multi-core capture Thread-Index: AQHU6TUZolXNuEnbuUCpahSBBxRO8qYo+TFw Date: Tue, 2 Apr 2019 16:13:30 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4341B4@irsmsx110.ger.corp.intel.com> References: <20190402043318.20382-3-vipin.varghese@intel.com> <20190402091836.35779-1-vipin.varghese@intel.com> <20190402091836.35779-3-vipin.varghese@intel.com> In-Reply-To: <20190402091836.35779-3-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVlYTc5ZmYtMTZjNi00MDA2LWExMDMtM2EzMzY2Y2IyNTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGNsaGgyXC9OR3c2V1dDWElzRFpyWGVkUG5oZ2wwZ0RlTHVoMVp0cXI4RHF4SVFETW50NVZFXC9sc3ByUytnSlNCIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402161330.h3-k1D8ya5-hoQ2T2Xktb18TWGzqwpQVFqrgRZOIZeU@z> > -----Original Message----- > From: Varghese, Vipin >=20 > @@ -152,7 +157,7 @@ pdump_usage(const char *prgname) > "[ring-size=3Ddefault:16384]," > "[mbuf-size=3Ddefault:2176]," > "[total-num-mbufs=3D mbufs>default:65535]'\n", > - prgname); > + prgname, CMD_LINE_OPT_MULTI, IMO, simple short options can be used instead of long, as this option don'= t have any arguments to pass. >=20 > +static int > +dump_packets_core(void *arg) > +{ > + struct pdump_tuples *pt =3D (struct pdump_tuples *) arg; > + > + printf(" core (%u); port %u device (%s) queue %u\n", > + rte_lcore_id(), pt->port, pt->device_id, pt->queue); Log message can be improved to be " packet_dump for port running on = core " > + fflush(stdout); Why is fflush used here and in below other places? >=20 > +The ``--multi`` command line option is optional argument. If passed, > +capture will be running on unqiue cores for all ``--pdump`` options. If Typo unique Thanks, Reshma