From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 71CD81B108 for ; Wed, 3 Apr 2019 11:25:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 02:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="146199404" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2019 02:25:12 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:25:11 +0100 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by irsmsx112.ger.corp.intel.com ([169.254.1.167]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 10:25:11 +0100 From: "Pattan, Reshma" To: "Hajkowski, MarcinX" , "Hunt, David" CC: "dev@dpdk.org" , "Hajkowski, MarcinX" Thread-Topic: [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds Thread-Index: AQHU6S1aUiMtER2BekK/la+nkVkVf6YqKgUQ Date: Wed, 3 Apr 2019 09:25:10 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A43462C@irsmsx110.ger.corp.intel.com> References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> <20190402082121.5472-1-marcinx.hajkowski@intel.com> <20190402082121.5472-4-marcinx.hajkowski@intel.com> In-Reply-To: <20190402082121.5472-4-marcinx.hajkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM5ODAyNTUtZTk5Yi00OTY2LWJmZTEtNzI5NTAwNDY4YTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSzU5aE4wSDd1YVE5MHlsNmRGOW9DSHFId0JhUTkrYUZjaWZHaElJenU3WTFBeWpDbDZmazF3U2d0WFBBdjRoMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 09:25:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski > + RTE_LOG(DEBUG, GUEST_CLI, "Not expected command has > been received.\n"); Instead of : "Not expected command has been received ". How about, Receive= d invalid response from host, expecting NACK/ACK? But let's hear from others. > + int result; > + ret =3D check_response_cmd(res->lcore_id, &result); > + if (ret < 0) { > + RTE_LOG(DEBUG, GUEST_CLI, "No confirmation for sent msg > received\n"); > + } else { > + cmdline_printf(cl, "Ack for sent msg received with result: > %s.\n", > + result =3D=3D 1 ? "SUCCESS" : "ERROR"); > + } > } In else statement how about just checking for result ACK/NACK and have log = saying received ACK /received NACK for msg Thanks, Reshma =20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A202DA0679 for ; Wed, 3 Apr 2019 11:25:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F03411B112; Wed, 3 Apr 2019 11:25:14 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 71CD81B108 for ; Wed, 3 Apr 2019 11:25:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 02:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="146199404" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2019 02:25:12 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:25:11 +0100 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by irsmsx112.ger.corp.intel.com ([169.254.1.167]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 10:25:11 +0100 From: "Pattan, Reshma" To: "Hajkowski, MarcinX" , "Hunt, David" CC: "dev@dpdk.org" , "Hajkowski, MarcinX" Thread-Topic: [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds Thread-Index: AQHU6S1aUiMtER2BekK/la+nkVkVf6YqKgUQ Date: Wed, 3 Apr 2019 09:25:10 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A43462C@irsmsx110.ger.corp.intel.com> References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> <20190402082121.5472-1-marcinx.hajkowski@intel.com> <20190402082121.5472-4-marcinx.hajkowski@intel.com> In-Reply-To: <20190402082121.5472-4-marcinx.hajkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM5ODAyNTUtZTk5Yi00OTY2LWJmZTEtNzI5NTAwNDY4YTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSzU5aE4wSDd1YVE5MHlsNmRGOW9DSHFId0JhUTkrYUZjaWZHaElJenU3WTFBeWpDbDZmazF3U2d0WFBBdjRoMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403092510.JPTxjJHIrE0BCAPjyKkd5psjq-QLXnxl4SotLK2YYn0@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski > + RTE_LOG(DEBUG, GUEST_CLI, "Not expected command has > been received.\n"); Instead of : "Not expected command has been received ". How about, Receive= d invalid response from host, expecting NACK/ACK? But let's hear from others. > + int result; > + ret =3D check_response_cmd(res->lcore_id, &result); > + if (ret < 0) { > + RTE_LOG(DEBUG, GUEST_CLI, "No confirmation for sent msg > received\n"); > + } else { > + cmdline_printf(cl, "Ack for sent msg received with result: > %s.\n", > + result =3D=3D 1 ? "SUCCESS" : "ERROR"); > + } > } In else statement how about just checking for result ACK/NACK and have log = saying received ACK /received NACK for msg Thanks, Reshma =20