From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CBFA61BB92; Thu, 18 Apr 2019 17:14:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 08:14:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,366,1549958400"; d="scan'208";a="317039408" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga005.jf.intel.com with ESMTP; 18 Apr 2019 08:14:09 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by IRSMSX154.ger.corp.intel.com ([169.254.12.101]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 16:14:09 +0100 From: "Pattan, Reshma" To: "Hunt, David" , "dev@dpdk.org" CC: "Hunt, David" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun Thread-Index: AQHU75vwyerA3+dQFk6EQZH2HzcUv6ZCEwmg Date: Thu, 18 Apr 2019 15:14:07 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A449608@irsmsx110.ger.corp.intel.com> References: <20190410124910.24537-1-david.hunt@intel.com> In-Reply-To: <20190410124910.24537-1-david.hunt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjc0YTQ2ZTEtMDc4ZC00OGVkLWI2NjEtMmIwMjkxNTZmOTU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTTZHNDRGMzJ3R20yT01mYW5sWXUyR3pSQ3BjQ2ZNV2g4dUxkY1wvN0FPTTNicFJLVjZibW1XXC81RFhEMmpIM0pKIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 15:14:12 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, April 10, 2019 1:49 PM > To: dev@dpdk.org > Cc: Hunt, David ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer > overrun >=20 > The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet > the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, Couple of nit-picks, :%s/ attempt/ attempt > which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to > RTE_MAX_LCORE_FREQS. >=20 > Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") > Coverity issue: 337660 Candidate for stable@dpdk.org? Acked-by: Reshma Pattan Thanks, Reshma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 365CCA00E6 for ; Thu, 18 Apr 2019 17:14:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AD6D1BB9D; Thu, 18 Apr 2019 17:14:14 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CBFA61BB92; Thu, 18 Apr 2019 17:14:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 08:14:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,366,1549958400"; d="scan'208";a="317039408" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga005.jf.intel.com with ESMTP; 18 Apr 2019 08:14:09 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by IRSMSX154.ger.corp.intel.com ([169.254.12.101]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 16:14:09 +0100 From: "Pattan, Reshma" To: "Hunt, David" , "dev@dpdk.org" CC: "Hunt, David" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun Thread-Index: AQHU75vwyerA3+dQFk6EQZH2HzcUv6ZCEwmg Date: Thu, 18 Apr 2019 15:14:07 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A449608@irsmsx110.ger.corp.intel.com> References: <20190410124910.24537-1-david.hunt@intel.com> In-Reply-To: <20190410124910.24537-1-david.hunt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjc0YTQ2ZTEtMDc4ZC00OGVkLWI2NjEtMmIwMjkxNTZmOTU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTTZHNDRGMzJ3R20yT01mYW5sWXUyR3pSQ3BjQ2ZNV2g4dUxkY1wvN0FPTTNicFJLVjZibW1XXC81RFhEMmpIM0pKIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418151407.-M9jAV33ZZ35l4Lz7sYr_Ib8cXHenrNrn2JbjdB2mbU@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, April 10, 2019 1:49 PM > To: dev@dpdk.org > Cc: Hunt, David ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer > overrun >=20 > The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet > the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, Couple of nit-picks, :%s/ attempt/ attempt > which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to > RTE_MAX_LCORE_FREQS. >=20 > Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") > Coverity issue: 337660 Candidate for stable@dpdk.org? Acked-by: Reshma Pattan Thanks, Reshma