From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1985A0487 for ; Mon, 1 Jul 2019 12:33:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84E282C60; Mon, 1 Jul 2019 12:33:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 70DC82C23 for ; Mon, 1 Jul 2019 12:33:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 03:11:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,438,1557212400"; d="scan'208";a="184219635" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 01 Jul 2019 03:11:27 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.217]) by irsmsx105.ger.corp.intel.com ([169.254.7.184]) with mapi id 14.03.0439.000; Mon, 1 Jul 2019 11:11:21 +0100 From: "Pattan, Reshma" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 7/8] raw/ioat: add statistics functions Thread-Index: AQHVLNUGTtvbmnAUiEqJRpaR6rIlEqaxSTZw Date: Mon, 1 Jul 2019 10:11:20 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4894DC@irsmsx110.ger.corp.intel.com> References: <20190530212525.40370-1-bruce.richardson@intel.com> <20190627104055.8244-1-bruce.richardson@intel.com> <20190627104055.8244-8-bruce.richardson@intel.com> In-Reply-To: <20190627104055.8244-8-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmEyYjZkMWItZGVmOS00ZTBkLTljYmUtNTY5M2YyMWJiY2JmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiME1BR1N0bmxcL2NqNG1PM2l0YlhcLzliNzdTVFdkRzFSMHdmelRIZUFjU3lqcFBkbmt5cXRPWk1FMnRvOEtwTUdyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 7/8] raw/ioat: add statistics functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 27, 2019 11:41 AM > To: dev@dpdk.org > +static int > +ioat_xstats_get(const struct rte_rawdev *dev, const unsigned int ids[], > + uint64_t values[], unsigned int n) > +{ > + const struct rte_ioat_rawdev *ioat =3D dev->dev_private; > + unsigned int i; > + > + for (i =3D 0; i < n; i++) { > + switch (ids[i]) { > + case 0: values[i] =3D ioat->enqueue_failed; break; > + case 1: values[i] =3D ioat->enqueued; break; > + case 2: values[i] =3D ioat->started; break; > + case 3: values[i] =3D ioat->completed; break; > + default: values[i] =3D 0; break; > + } > + } > + return n; Should this return n or how many actually filled ? Thanks, Reshma