From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E7758212 for ; Mon, 6 Oct 2014 16:09:18 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 06 Oct 2014 07:16:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,664,1406617200"; d="scan'208";a="610270634" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 06 Oct 2014 07:16:24 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.253]) by IRSMSX102.ger.corp.intel.com ([169.254.2.200]) with mapi id 14.03.0195.001; Mon, 6 Oct 2014 15:16:23 +0100 From: "Pattan, Reshma" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH v3] distributor_app: new sample app Thread-Index: AQHP3Jrg0aT67DPn+0CmG3jigM5MIJwZexeAgAAMNwCAABbFAIABs1bw///0VQCAAAuBAIAACHUAgAfH1lA= Date: Mon, 6 Oct 2014 14:16:22 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831FE2177E@IRSMSX109.ger.corp.intel.com> References: <1411568210-2555-1-git-send-email-reshma.pattan@intel.com> <1412073577-12248-1-git-send-email-reshma.pattan@intel.com> <20140930113445.GB2193@hmsreliant.think-freely.org> <20140930121828.GA9312@BRICHA3-MOBL> <20140930133958.GG2193@hmsreliant.think-freely.org> <3AEA2BF9852C6F48A459DA490692831FE20FB6@IRSMSX109.ger.corp.intel.com> <20141001145620.GB24028@localhost.localdomain> <20141001153730.GA9292@BRICHA3-MOBL> <20141001160746.GF24028@localhost.localdomain> In-Reply-To: <20141001160746.GF24028@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 14:09:19 -0000 > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Wednesday, October 1, 2014 5:08 PM > To: Richardson, Bruce > Cc: Pattan, Reshma; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app > = > > > > > > > > 1)I had sent v5 patch which handles graceful shutdown of rx and tx > > > > threads upon SIGINT > > > I see it and will take a look shortly, thanks. > > > > > > > 2)Worker thread graceful shutdown was not handled as of now as it n= eeds > some change in lcore_worker logic , which will be done in future enhancem= ents. > > > Not sure I understand what you mean here. Can you elaborate? > > > rte_distributor_process which runs as part of rx thread will process incomi= ng packets and checks for any requests for the packets from worker threads . If request is seen, it adds the packet/work to particular workers back log= and proceed with processing of next packet. If no request seen the packet index will not be incremented and the while = loop which is conditionally based on packet indexing runs in a continuous = loop without breaking and rx thread will not proceed with next statement ex= ecution until unless rte_distributor_process comes out of while loop. = This issue happens only when we enable graceful shutdown logic for both rx/= worker threads, as workers threads gets killed and no request seen by rx th= read and it stucks. = Hence as of now graceful shutdown logic is provided only for rx thread. For= worker threads will check what can be done in next enhancements. = Thanks, Reshma > > > > 3)Freeing of mempool is also not handled , as the framework support= is not > available. > > > Ew, I hadn't noticed that, freeing of mempools seems like something > > > we should implement. > > > > > > > 4)Cleaning of rx/tx queues not done, as it needs some extensive log= ic > which we haven't planned as of now. Will check the possibility of doing i= t in > future enhancements i.e in next version of sample application. > > > We can't just flush the queues after we shutdown the workers? I > > > presume a queue flush operation exists, yes? > > > Neil > > > > Other than code hygiene, which does have some value in itself, I can't > > really see what the practical point of such cleanup would be. > > > This is really the only assertion I'm trying to make. I understand this = application > won't suffer from exiting uncleanly, and that makes the need for preformi= ng > cleanup little more than overhead. > = > But that said, hygine is exactly the point I'm driving at here. These ar= e example > applications, that presumably people look at when writing their own apps.= If > you don't do things properly, people looking at your code are less likely= to do > them as well. Even if it doesn't hurt for you to exit uncleanly, it will= hurt > someone, and if they look to these examples as a source of best practices= , it > seems to me that it would be in everyones interest, if best practices were > demonstrated. > = > Neil -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.