From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 80E5D7F25 for ; Fri, 14 Nov 2014 09:36:04 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 14 Nov 2014 00:46:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,384,1413270000"; d="scan'208";a="631857618" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2014 00:46:00 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 14 Nov 2014 08:44:26 +0000 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.99]) by IRSMSX151.ger.corp.intel.com ([169.254.4.10]) with mapi id 14.03.0195.001; Fri, 14 Nov 2014 08:44:26 +0000 From: "Pattan, Reshma" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7] distributor_app: new sample app Thread-Index: AQHP933RnMEMnwg5mUaqqbYKGffRzJxPEE2AgBASvwCAALwUMA== Date: Fri, 14 Nov 2014 08:44:25 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831FE35F2D@IRSMSX109.ger.corp.intel.com> References: <1413554380-22809-1-git-send-email-reshma.pattan@intel.com> <1415029784-16638-1-git-send-email-reshma.pattan@intel.com> <2996275.IBF3pFpS8C@xps13> In-Reply-To: <2996275.IBF3pFpS8C@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 08:36:05 -0000 Archived-At: List-Archive: > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 13, 2014 9:30 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app >=20 > Hi Reshma, >=20 > > > From: Reshma Pattan > > > > > > A new sample app that shows the usage of the distributor library. > > > This app works as follows: > > > > > > * An RX thread runs which pulls packets from each ethernet port in tu= rn > > > and passes those packets to worker using a distributor component. > > > * The workers take the packets in turn, and determine the output port > > > for those packets using basic l2forwarding doing an xor on the sour= ce > > > port id. > > > * The RX thread takes the returned packets from the workers and enque= ue > > > those packets into an rte_ring structure. > > > * A TX thread pulls the packets off the rte_ring structure and then > > > sends each packet out the output port specified previously by the > > > worker > > > * Command-line option support provided only for portmask. > > > > > > v5 change: > > > * Handled gracefull shutdown of rx and tx threads upon SIGINT. > > > > > > v6 change: > > > * modified graceful shutdown logic to handle all threads upon SIGINT > > > * removed call to rte_eal_pci_probe() > > > * added seperate print_stats function > > > > > > v7 change: > > > * passing NULL as rxconf/txconf parameter for rx/tx queue setup > > > * removed zero-ed fields from port conf structure > > > * fixed style related comments > > > > > > > > > Signed-off-by: Bruce Richardson > > > Signed-off-by: Reshma Pattan > > > > Acked-by: Pablo de Lara >=20 > Before applying this patch, I have 2 comments: > - Other examples directories don't have _app suffix. > - checkpatch reports "switch and case should be at the same indent" >=20 > If you agree I will fix these 2 minor issues before applying. Fine with me. You can proceed. Thanks, Reshma >=20 > Thanks > -- > Thomas