From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 27EBD68BE for ; Thu, 11 Dec 2014 17:58:48 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 11 Dec 2014 08:58:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,558,1413270000"; d="scan'208";a="646152102" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2014 08:58:47 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX108.ger.corp.intel.com ([169.254.11.150]) with mapi id 14.03.0195.001; Thu, 11 Dec 2014 16:58:43 +0000 From: "Pattan, Reshma" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support Thread-Index: AQHQEJV0kC//fc5YjUeaKzg6684P85yKohEg Date: Thu, 11 Dec 2014 16:58:42 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831FE4C138@IRSMSX109.ger.corp.intel.com> References: <533710CFB86FA344BFBF2D6802E60286C9D147@SHSMSX101.ccr.corp.intel.com> <1417787182-20712-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1417787182-20712-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 16:58:49 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, December 5, 2014 1:46 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support >=20 > When using multiple processes, the TX function used in all processes shou= ld be > the same, otherwise the secondary processes cannot transmit more than tx- > ring-size - 1 packets. > To achieve this, we extract out the code to select the ixgbe TX function = to be > used into a separate function inside the ixgbe driver, and call that from= a > secondary process when it is attaching to an already-configured NIC. >=20 > Testing with symmetric MP app shows that we are able to RX and TX from bo= th > primary and secondary processes once this patch is applied. >=20 > Signed-off-by: Bruce Richardson >=20 > ---- > V2 Changes: > * Moved check for primary/secondary process into set_tx_function instead > of ixgbe_txq_vec_setup, which reduces scope of diff. > * Added/cleaned up some code comments for this change > --- Acked-by: Reshma Pattan With comment " checkpatch shows whitespace errors which got copied from old= code"