From: "Wiles, Roger Keith" <keith.wiles@windriver.com>
To: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [please ignore this test email]
Date: Sun, 17 Aug 2014 00:10:33 +0000 [thread overview]
Message-ID: <3BBDBC3C-CC70-4B64-82C3-BC9E064BDC5B@windriver.com> (raw)
In-Reply-To: <3556499.hMzHJM9L0j@xps13>
Test 1
On Aug 15, 2014, at 5:41 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> Hi Keith,
>
> 2014-08-14 21:55, Wiles, Roger Keith:
>> /* #### Changed the next line to use (3,13,8) instead of (3,14,0) KeithW */
>> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) )
>> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
>> #ifdef NETIF_F_RXHASH
>> #define PKT_HASH_TYPE_L3 0
>> static inline void
>> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
>> {
>> skb->rxhash = hash;
>> }
>> #endif /* NETIF_F_RXHASH */
>> #endif /* < RHEL7 */
>> #endif /* < 3.14.0 */
>
Test 2
Test 3
> I really don't understand why changing condition from
> < 3.14.0
> to
> < 3.13.8
> would be better?
> This function appeared in 3.14.0. Maybe that Ubuntu backported it for their
> 12.04 version, so it must be handled with a specific Ubuntu check as it was
> already done for Ubuntu 14.04:
> #if (!(UBUNTU_RELEASE_CODE == UBUNTU_RELEASE_VERSION(14,4) &&
> UBUNTU_KERNEL_CODE >= UBUNTU_KERNEL_VERSION(3,13,0,30,54)))
>
> Please help to improve what is done in master branch by providing patches.
>
Test 4
> Note: please do not top post and try to use cite mark '>'
>
> Thanks
> --
> Thomas
Thanks
++Keith
Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
next prev parent reply other threads:[~2014-08-17 0:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 21:44 [dpdk-dev] 1.7.0 release failed to compile on linux Qiaobing Xie
2014-08-14 21:55 ` Wiles, Roger Keith
2014-08-14 22:24 ` Aws Ismail
2014-08-14 22:57 ` Qiaobing Xie
2014-08-14 23:27 ` Qiaobing Xie
2014-08-15 22:41 ` Thomas Monjalon
2014-08-17 0:10 ` Wiles, Roger Keith [this message]
2014-08-14 22:15 ` Aws Ismail
2014-08-15 0:16 ` Neil Horman
2014-08-15 0:31 ` Qiaobing Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BBDBC3C-CC70-4B64-82C3-BC9E064BDC5B@windriver.com \
--to=keith.wiles@windriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).