From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by dpdk.org (Postfix) with ESMTP id CD964231C for ; Sun, 17 Aug 2014 02:07:18 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s7H0AXDo014470 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Sat, 16 Aug 2014 17:10:33 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.39]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Sat, 16 Aug 2014 17:10:33 -0700 From: "Wiles, Roger Keith" To: "" Thread-Topic: [dpdk-dev] [please ignore this test email] Thread-Index: AQHPua+piavI0s6sOUGsIiGz9swzow== Date: Sun, 17 Aug 2014 00:10:33 +0000 Message-ID: <3BBDBC3C-CC70-4B64-82C3-BC9E064BDC5B@windriver.com> References: <53ED2DBF.4070003@gmail.com> <4B613BEE-2D07-417D-ACA3-6C228FADB14E@windriver.com> <3556499.hMzHJM9L0j@xps13> In-Reply-To: <3556499.hMzHJM9L0j@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.162] Content-Type: text/plain; charset="us-ascii" Content-ID: <3CAAFA6A45E6114FAC9743661CE1DDAD@local> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [please ignore this test email] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Aug 2014 00:07:20 -0000 Test 1=20 On Aug 15, 2014, at 5:41 PM, Thomas Monjalon wr= ote: > Hi Keith, >=20 > 2014-08-14 21:55, Wiles, Roger Keith: >> /* #### Changed the next line to use (3,13,8) instead of (3,14,0) KeithW= */ >> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) ) >> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D RHEL_RELEASE_VERSION(= 7,0))) >> #ifdef NETIF_F_RXHASH >> #define PKT_HASH_TYPE_L3 0 >> static inline void >> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) >> { >> skb->rxhash =3D hash; >> } >> #endif /* NETIF_F_RXHASH */ >> #endif /* < RHEL7 */ >> #endif /* < 3.14.0 */ >=20 Test 2 Test 3 > I really don't understand why changing condition from > < 3.14.0 > to > < 3.13.8 > would be better? > This function appeared in 3.14.0. Maybe that Ubuntu backported it for the= ir > 12.04 version, so it must be handled with a specific Ubuntu check as it w= as > already done for Ubuntu 14.04: > #if (!(UBUNTU_RELEASE_CODE =3D=3D UBUNTU_RELEASE_VERSION(14,4) && > UBUNTU_KERNEL_CODE >=3D UBUNTU_KERNEL_VERSION(3,13,0,30,54))) >=20 > Please help to improve what is done in master branch by providing patches= . >=20 Test 4 > Note: please do not top post and try to use cite mark '>' >=20 > Thanks > --=20 > Thomas Thanks ++Keith Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533