From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D2D201B253 for ; Wed, 18 Oct 2017 04:25:08 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2017 19:25:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,393,1503385200"; d="scan'208";a="1026275551" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2017 19:25:06 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Wed, 18 Oct 2017 03:25:05 +0100 From: "Mokhtar, Amr" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Power, Niall" , "Macnamara, Chris" Thread-Topic: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library Thread-Index: AQHTOYzBtEwKLLTcWU+HBlELLdGEUqLmSDuAgAK0W9A= Date: Wed, 18 Oct 2017 02:25:05 +0000 Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236EC43A6A@IRSMSX101.ger.corp.intel.com> References: <1506735475-77078-1-git-send-email-amr.mokhtar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjI1N2QwY2YtMzc4NC00YWYyLWIwZTEtYmZlZjExY2Y2YjNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InV3Y0VaMDcxTHB3YnZjRmtuNlNhbkk5OFo3YnZNcmFKVFN1YVBFUVpIXC9rPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 02:25:09 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday 16 October 2017 11:04 > To: Mokhtar, Amr ; dev@dpdk.org > Cc: Power, Niall ; Macnamara, Chris > ; Mokhtar, Amr > Subject: RE: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Amr Mokhtar > > Sent: Saturday, September 30, 2017 2:38 AM > > To: dev@dpdk.org > > Cc: Power, Niall ; Macnamara, Chris > > ; Mokhtar, Amr > > Subject: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library > > >=20 > You are adding a new library here, so I think it deserves a description h= ere (also > for the other patches). Wrong command caused the cover letter to go separately. You may find it @ h= ttp://dpdk.org/ml/archives/dev/2017-September/077027.html Recovered in v2 patch. >=20 > This is also a good patch to mention the new library in release notes (in= stead of > leaving it to the documentation patch). This was considered in v2 patch. Thanks. >=20 >=20 > > Signed-off-by: Amr Mokhtar >=20 > ... >=20 > b/lib/librte_bbdev/Makefile > > new file mode 100644 > > index 0000000..519d49f > > --- /dev/null > > +++ b/lib/librte_bbdev/Makefile >=20 > ... >=20 > > + > > +# versioning export map > > +EXPORT_MAP :=3D rte_bbdev_version.map > > + > > +# library dependencies > > +DEPDIRS-y +=3D lib/librte_eal lib/librte_mempool lib/librte_kvargs >=20 > Since this patch, DEPDIRS in libraries and drivers are deprecated: > http://dpdk.org/dev/patchwork/patch/22298/ Done. >=20 >=20 > > + > > +include $(RTE_SDK)/mk/rte.lib.mk