From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <amr.mokhtar@intel.com> Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C49D21B767 for <dev@dpdk.org>; Sat, 14 Apr 2018 01:37:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 16:37:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="191384161" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 13 Apr 2018 16:37:41 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by irsmsx105.ger.corp.intel.com ([169.254.7.163]) with mapi id 14.03.0319.002; Sat, 14 Apr 2018 00:37:40 +0100 From: "Mokhtar, Amr" <amr.mokhtar@intel.com> To: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH] baseband/turbo_sw: offload cost measurement test Thread-Index: AQHTzB4nbdr7UREIX0mW+eSLvKY/o6P/ZrtQ Date: Fri, 13 Apr 2018 23:37:40 +0000 Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236ECAA11A@IRSMSX101.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-2-kamilx.chalupnik@intel.com> In-Reply-To: <20180404140602.9344-2-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzljNmY1OGEtMWFmZC00OTE1LWIwZjgtZGIyYWJiN2Y3NGRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJqY3pkc1Y4eEdDc3BGVCt4eG9FMVB3NHZMM1pOZVFDSTBycXpFTXpIekJsRHczUUUwdnNqcHl1NDZRWG5TZncxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] baseband/turbo_sw: offload cost measurement test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 13 Apr 2018 23:37:44 -0000 > -----Original Message----- > From: Chalupnik, KamilX > Sent: Wednesday 4 April 2018 15:06 > To: dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX > <kamilx.chalupnik@intel.com> > Subject: [PATCH] baseband/turbo_sw: offload cost measurement test >=20 > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com> >=20 > New test created to measure offload cost. > Changes were introduced in API, turbo software driver > and test application >=20 > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com> > b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > index 302abf5..70691f3 100644 > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > @@ -9,6 +9,7 @@ > #include <rte_malloc.h> > #include <rte_ring.h> > #include <rte_kvargs.h> > +#include <rte_cycles.h> >=20 > #include <rte_bbdev.h> > #include <rte_bbdev_pmd.h> > @@ -20,18 +21,6 @@ >=20 > #define DRIVER_NAME turbo_sw >=20 > -/* Turbo SW PMD logging ID */ > -static int bbdev_turbo_sw_logtype; > - > -/* Helper macro for logging */ > -#define rte_bbdev_log(level, fmt, ...) \ > - rte_log(RTE_LOG_ ## level, bbdev_turbo_sw_logtype, fmt "\n", \ > - ##__VA_ARGS__) > - > -#define rte_bbdev_log_debug(fmt, ...) \ > - rte_bbdev_log(DEBUG, RTE_STR(__LINE__) ":%s() " fmt, __func__, \ > - ##__VA_ARGS__) > - Why deleting logging macros? This prevents turbo_sw driver from building.=20 Please ignore my previous Ack, it was set to this patch wrongly.. Thanks, Amr